fix(identit/models): update_traits typing to support dicts #6371
+16
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The trait_value field in SDKTraitData now correctly accepts both: - Structured SDKTraitValueData (from serializer validation via TraitValueField) - Raw primitive values (str, int, bool, float) when called directly - None (to delete traits) This aligns the type definition with the actual runtime behavior of update_traits() and generate_traits() methods which handle both cases via Trait.generate_trait_value_data().
|
You have run out of free Bugbot PR reviews for this billing cycle. This will reset on December 10. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
Contributor
Docker builds report
|
…ypes The value field can be str, int, bool, or float based on the trait's actual value type, not just str.
- Remove unused type: ignore comments in launch_darkly/services.py now that SDKTraitData accepts raw trait values - Update get_transient_identifier to handle both SDKTraitValueData and raw primitive values with proper type narrowing
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6371 +/- ##
=======================================
Coverage 98.02% 98.02%
=======================================
Files 1282 1282
Lines 45498 45500 +2
=======================================
+ Hits 44600 44602 +2
Misses 898 898 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4 tasks
Tests cover: - Structured SDKTraitValueData format (from serializer validation) - Raw primitive values (str, int, bool, float) - None values being skipped - Empty list returning UUID - Same value in structured vs raw format producing same hash
…nt_identifier The function only receives SDKTraitValueData from serializer paths, so a type: ignore comment is sufficient to handle the broadened TraitValue type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature!Changes
The trait_value field in SDKTraitData now correctly accepts both:
This aligns the type definition with the actual runtime behavior of update_traits() and generate_traits() methods which handle both cases via Trait.generate_trait_value_data().
How did you test this code?
Please describe.