re-write cruct #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add ConfigSource trait and merge_sections helper - Implement ConfigFileSource accepting an optional FileFormat - Feature-gated ClapSource for CLI flags (cli feature) - Build ConfigBuilder in macro expansion (preserves existing format attribute) - Update `impl_block.rs` to use `builder.load()` under the hood - Add unit tests for merge logic and file/CLI sources - Add integration tests for `#[cruct]` macro with and without cli feature
…ation - Update `ClapSource::new()` in cruct_shared to accept ArgMatches instead of Command - Fix procedural macro implementation to properly parse CLI arguments: - Generate CLI command parsing with get_matches() before creating ClapSource - Add dynamic CLI flag generation based on struct fields in impl_block.rs - Ensure feature-gated CLI integration works with config builder pattern This resolves type mismatches in the macro-generated code and enables actual CLI argument parsing when using the #[cruct] macro with the 'cli' feature enabled.
chikof
added
assigned
- Rename `get_parser_by_extension` to `get_parser` and improve error handling - Add `get_file_extension` utility with proper error for missing extensions - Expand scalar type support with implementations for numeric types, char, and usize/isize - Introduce `parse_value` helper for consistent type conversion errors - Refactor config sources to use centralized extension handling - Remove obsolete `UnsupportedType` error variant - Update YAML and TOML parsers to use more explicit imports - Improve error messages with contextual information about parsing failures
This commit also features the implementation of loading multiple config files at once with a priority.
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment Thanks for integrating Codecov - We've got you covered ☂️ |
chikof
changed the title
This error was because the compiler_error gave an error all the time and coulnd't even send a proper test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Linked Issues