Bundle Fuse Installer with Release #357
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perfectmak
force-pushed
the
feature/ch16830/bundle-fuse-installer
branch
from
b14756a
to
3d70d78
Compare
perfectmak
changed the title
perfectmak
force-pushed
the
feature/ch16830/bundle-fuse-installer
branch
from
7a810be
to
93e7595
Compare
gpuente
reviewed
Nov 19, 2020
|
Thanks @perfectmak for your response! I going to work on a refactor based on your code to make the installation process work as a helper function so in that way we can call the installation on demand just when the user needs it 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
TODO
The
FuseDaemoninstaller needs to be triggered when a user wants to activate the fuse drive and theGetFuseDriveStatus()rpc call returnsNOT_INSTALLED. The calling code needs to listen on thesuccessorerrorevent to know the status of installation. If the installation is successful, then the client can make theToggleFuseDrive()rpc call to mount the drive on the users computer.