New interceptors and updates to existing ones #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The allowed origin is configurable from env variables and in state it looks for `:cors-url` under `:deps` key - It also supports `preflight` requests
1. JWT has to skip check if request is preflight, so requests with `:options` method is skipped 2. Additional check presence of authorization token in the headers, as it was throwing exceptions due to usage of `str/split`
- Tiny but subtle improvement of params interceptor - Mock and Peridot library used for testing purposes as it allows us to simply mock multipart requests, and many others, but that's what we needed at the moment.
1. The first change I propose here is avoiding nesting coercion result under param type (path, query, form) and just keeping it under params 2. Validation error returns humanized details
If the back-end is Clojure and Front-end Javascript we encounter inconsistency of keys in the context of the language.
Hence the experimental solution that we can discuss:
1. kebab-camel interceptor transforms each key upon request to kebab:
- original request `{:request {:params {:paramKey1 1 :paramKey2 2 :paramKey3 3}}}`
- request after interceptor `{:request {:params {:param-key-1 1 :param-key-2 2 :param-key-3 3}}}`
2. The keys in the response body are also transformed from kebab to camel:
- response before interceptor - `{:response {:body {:param-key-1 1 :param-key-2 2 :param-key-3 3}}}`
- after `{:response {:body {:paramKey1 1 :paramKey2 2 :paramKey3 3}}}`
P.S. `slf4j-simple` is also added to deps to finally get rid of warning at the beginning of http server.
agigao
changed the title
|
PR included wrapping |
soulflyer
reviewed
Aug 3, 2023
|
Should probably be 4 PRs, (This is only a comment, not a request for change) |
g-krisztian
reviewed
Aug 15, 2023
src/xiana/interceptor.clj
Outdated
Comment on lines
173
to
174
| schemas (or (get-in state [:request-data :match :data method :parameters]) | ||
| (get-in state [:request-data :match :data :parameters])) |
There was a problem hiding this comment.
I'd keep the merge as it was, to be able to define the path related parameters once, and method parameters separately.
g-krisztian
reviewed
Aug 15, 2023
src/xiana/interceptor.clj
Outdated
Comment on lines
176
to
178
| (:path schemas) (valid? (:path schemas) path) | ||
| (:query schemas) (valid? (:query schemas) query) | ||
| (:form schemas) (valid? (:form schemas) form-params))] |
There was a problem hiding this comment.
How the :query and :form parameters are processed if you defined :path parameters TOO?
There was a problem hiding this comment.
Yup, the change undone.
agreed. |
agigao
force-pushed
the
interceptor-updates
branch
from
8271f7b
to
5f1b83a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New interceptors and updates to existing ones
CORS headers interceptor
:cors-urlunder:depskeypreflightrequestsError response
Error interceptor wrapped in
bad requestresponse instead of 200Multipart/form-data support
Coercion improvements
kebab-camel request/request - experimental feature, up for discussion
If the back-end is Clojure and Front-end Javascript we encounter inconsistency of keys in the context of the language.
Hence the experimental solution that we can discuss:
{:request {:params {:paramKey1 1 :paramKey2 2 :paramKey3 3}}}{:request {:params {:param-key-1 1 :param-key-2 2 :param-key-3 3}}}{:response {:body {:param-key-1 1 :param-key-2 2 :param-key-3 3}}}{:response {:body {:paramKey1 1 :paramKey2 2 :paramKey3 3}}}P.S.
slf4j-simpleis also added todeps.ednto finally get rid of warning at the beginning of http server.Tester info
All tests are provided
Completion Checklist