Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Getting started fix #255

Merged
merged 2 commits into from
Aug 15, 2023
Merged

Getting started fix #255

merged 2 commits into from
Aug 15, 2023

Conversation

grinderrz
Copy link
Contributor

Fixed several problems in doc/getting-started.md:

  1. node is also required to run frontend.
  2. lein migrate create todos was failing with opaque message, turns out -n and -d arguments are required.
  3. mapv in view function results in java.lang.IllegalArgumentException: No implementation of method: :write-body-to-stream of protocol: #'ring.core.protocols/StreamableResponseBody found for class: clojure.lang.PersistentVector . Change to map solves the problem.
  4. Couple of indentation fixes.

@grinderrz grinderrz merged commit 0f4abb2 into main Aug 15, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agigao agigao agigao approved these changes

@Yacobh Yacobh Awaiting requested review from Yacobh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grinderrz @agigao