Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop game when GameOver instance is show #26

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

GrzegorzDuraj
Copy link

Hi,

I think Game should be stopped when UI.Dialogs.Components.GameOver.Instance.Show(isWon) is shown.

We can't use PauseLevel() method because of restart Button on GameOver Dialog.

What do you think ?

/br Greg

@FlipWebApps
Copy link
Owner

FlipWebApps commented Feb 7, 2017

Hi.

Thanks for the pull request, and I think it is a good idea to add that option. My only comment is that this should be optional (default to false) to not break existing games and as some cases might not want time pausing.

If you want to add an option to LevelManager (bool PauseTimeOnGameOver or something like that) that controls setting the time lines that you added and then I can merge this in. You also need to consider the case that they might exit to a different scene so might need to manually reset time other places to avoid thing freezing.

regards,
Mark

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants