Remove Nuclear 14 related bloat.

[Dogbone10]

About the PR

Why / Balance

There is a heap of content from Nuclear 14 that is either duplicates of pre-existing items, does not fit the lore (because it's from Fallout), lacks functionality, or would be better off being replaced by functional versions already in the game.
I'm removing that bloat content.

If there is ANYTHING specifically that you'd like me to restore, please say so.

Technical details

Removals of prototypes, files, textures, etc from the _Nuclear14 folders. This time I'm NOT going to touch the map files because last time I FUCKED my PR up so hard that HERE WE ARE on ATTEMPT 2.

Requirements

• I have tested all added content and changes.
• I have added media to this PR or it does not require an ingame showcase.

Licensing:

• I confirm that I am the creator of the content in this PR, and allow licensing it under the following license(s), or that the original author has given me permission to do so:
  • AGPL (https://github.com/Floof-Station/Panta-Rhei/blob/master/LICENSE-AGPLv3.txt)
  • MIT (https://github.com/Floof-Station/Panta-Rhei/blob/master/LICENSE-MIT.txt)

Breaking changes

Changelog

🆑

• remove: Excess N14 Content

[github-actions]

RSI Diff Bot; head commit a452895 merging into d12702e
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_Nuclear14/Structures/Decoration/cave_decor.rsi

State	Old	New	Status
boards_drought_ns-1			Removed
boards_drought_ns-2			Removed
boards_drought_ns-3			Removed
boards_drought_ns-4			Removed
boards_drought_ns-5			Removed
boards_drought_ns-6			Removed
boards_drought_we-1			Removed
boards_drought_we-2			Removed
boards_drought_we-3			Removed
boards_drought_we-4			Removed
boards_drought_we-5			Removed
boards_drought_we-6			Removed
boards_mammoth_ns-1			Removed
boards_mammoth_ns-2			Removed
boards_mammoth_ns-3			Removed
boards_mammoth_ns-4			Removed
boards_mammoth_ns-5			Removed
boards_mammoth_ns-6			Removed
boards_mammoth_we-1			Removed
boards_mammoth_we-2			Removed
boards_mammoth_we-3			Removed
boards_mammoth_we-4			Removed
boards_mammoth_we-5			Removed
boards_mammoth_we-6			Removed

Resources/Textures/_Nuclear14/Structures/Doors/SlantedDoors/fence_barbed.rsi

State	Old	New	Status
closed			Removed
open			Removed

Resources/Textures/_Nuclear14/Structures/Furniture/televisions.rsi

State	Old	New	Status
cabinet_tv			Removed
cabinet_tv1			Removed
radking_tv			Removed
redwood_tv			Removed
redwood_tv1			Removed
small_tv			Removed
small_tv1			Removed
tiny_tv			Removed
tiny_tv1			Removed
tube_tv			Removed
tube_tv1			Removed
wood_tv1			Removed

Resources/Textures/_Nuclear14/Structures/Storage/Closets/closetenclave.rsi

State	Old	New	Status
closet			Removed
closet_door			Removed
closet_open			Removed
welded			Removed

Resources/Textures/_Nuclear14/Structures/Storage/Crates/woodencrates.rsi

State	Old	New	Status
army_crate-1			Removed
army_crate-2			Removed
army_crate			Removed
plain_crate-1			Removed
plain_crate-2			Removed
plain_crate-3			Removed
plain_crate			Removed
sarsaparilla_crate-1			Removed
sarsaparilla_crate			Removed
wood_crate			Removed

Resources/Textures/_Nuclear14/Structures/Wallmounts/vdu.rsi

State	Old	New	Status
VDU			Removed
keyboard			Removed
screen			Removed

Resources/Textures/_Nuclear14/Structures/Wallmounts/walldecor.rsi

State	Old	New	Status
flag_arizona			Removed
flag_cali			Removed
flag_china			Removed
flag_colorado			Removed
flag_denver			Removed
flag_eastbos			Removed
flag_enclave			Removed
flag_legion			Removed
flag_ncr			Removed
flag_rangers			Removed
flag_us			Removed
flag_westbos			Removed

Edit: diff updated after a452895

[Dunrab]

Test fails are valid you are deleting things we use in maps.

[Mnemotechnician]

Some of these prototypes are still used in some of our maps and some are sometimes placed down by admins, please be mindful with what you are removing and add map migrations for the removed stuff.

[JFerrix]

This is not a good idea. The contents do not negatively impair the game in any way other than marginally increasing its size. The texture folder has a size on disk of 6.64MB, freeing this space while removing a substantial amount of potential mapping content is both not required and not beneficial.
I personally found the nuclear14 assets of great use when building a derelict ship for the shipyard event. These tiles and objects had no equivalent in the current codebase and removing them would greatly hinder creative expression of mappers and admins.
I explicitely disapprove of this request due to these reasons.

[Dogbone10]

This is not a good idea. The contents do not negatively impair the game in any way other than marginally increasing its size. The texture folder has a size on disk of 6.64MB, freeing this space while removing a substantial amount of potential mapping content is both not required and not beneficial. I personally found the nuclear14 assets of great use when building a derelict ship for the shipyard event. These tiles and objects had no equivalent in the current codebase and removing them would greatly hinder creative expression of mappers and admins. I explicitely disapprove of this request due to these reasons.

Alright. Admittedly this is why I keep asking people for what specifically to restore and what to ditch.
What about the Fallout faction flags and faux-loot-filled variants of the storages? Can those go?
I'd also gotten rid of the Enclave version of the secure storage and in last PR I took the word "pre-war" out of a few descriptions before the code got outta hand.

[JFerrix]

This is not a good idea. The contents do not negatively impair the game in any way other than marginally increasing its size. The texture folder has a size on disk of 6.64MB, freeing this space while removing a substantial amount of potential mapping content is both not required and not beneficial. I personally found the nuclear14 assets of great use when building a derelict ship for the shipyard event. These tiles and objects had no equivalent in the current codebase and removing them would greatly hinder creative expression of mappers and admins. I explicitely disapprove of this request due to these reasons.

Alright. Admittedly this is why I keep asking people for what specifically to restore and what to ditch. What about the Fallout faction flags and faux-loot-filled variants of the storages? Can those go? I'd also gotten rid of the Enclave version of the secure storage and in last PR I took the word "pre-war" out of a few descriptions before the code got outta hand.

The faction flags are fine to go honestly, the branded containers are, at least from my POV good to go aswell. But for example when it comes to tiles or things like storage tanks, walls, the rusted pipes, broken tables, all that stuff, those can be used to very great effect should we ever make maps or things like this that focus on exploration or general derelict or abandoned places.

[Mnemotechnician]

This is not a good idea. The contents do not negatively impair the game in any way other than marginally increasing its size. The texture folder has a size on disk of 6.64MB,

Actually, they DO negatively affect the game. Each N14 rsi has to be packed into the sprite atlas and kept loaded in the memory at all times. It wastes VRAM and RAM. 7 mb is the size of these textures in their compressed format (png); when uncompressed, they take 5-20 times more.

Also, SS14 generates sprite outlines and click maps on the cpu, which wastes a lot of cpu time (though I forgot whether that's done on-demand or during game loading. I'm pretty sure click maps are generated during loading for each sprite.)

[Dogbone10]

Going through my changes with a clear mind now: I have to stand by what I'm pitching to remove
The 17+ Floor boards are all variations of wood planks for covering holes. Maybe I'll put one or two back but we don't need SEVENTEEN different planks.
The breakable crates I removed had descriptions and names implying they would have assorted loot (Medical, Military, Engineering items, ech) but ONLY drop wood planks when destroyed. I don't see how this gives any positive gameplay feedback.
The rock walls I took out were already in the game- The Fallout versions just have slightly different drop chances. No one is making anything finely balanced enough that they need that- and it goes against what the people in salvage are familiar with. Plus, if anyone ever makes an update to the normal droprates/health/anything of the normal rocks, these ones will lag behind.
The fence I took out had a HORRIFICALLY broken sprite and was 64x64. Absurd- just use a normal fence. People are more used to the hitboxes and behavior of the originals anyways.
The flags- yeah those can go.
And the lockers and closets? 90% of the ones I took out were supposed to spawn with Fallout loot- but spawn empty because it didnt exist, meaning there were 1-3 clones of every fallout closet.
The unique ones I took out were the Medical wall closet, which has NO logic, no inventory, and again would just be negative feedback for players. No loot for you- just a prop.
I think the VDU (wallmount computer) is the only "cool" thing that I deliberately removed, and that was just because it has no UI. If we really want more unique computers we can always import the tabletop PCs from Cosmatic Drift, OR re-implement it with logic.

[SyaoranFox]

I am going to defer to Dunrab on this one. Mapping isn't my thing, but I am always of the policy of having content should we need it. I am also for the removal of bloat. I personally think we should remove the things Dunrab says are okay to, and keep the rest.