Skip to content

Sorting traits#278

Open
Raikyr0 wants to merge 28 commits intoFloof-Station:masterfrom
Raikyr0:SortingTraits
Open

Sorting traits#278
Raikyr0 wants to merge 28 commits intoFloof-Station:masterfrom
Raikyr0:SortingTraits

Conversation

@Raikyr0
Copy link
Contributor

@Raikyr0 Raikyr0 commented Mar 15, 2026

About the PR

Changes up the categories for traits, everything fitting under medical didn't feel right.
This PR splits Disability into Disability Physical and Disability Mental
Adds Cybernetics, Psionics and Lewd categories
replaces the Mental category with Feats - the DnD term

Most things that were under medical are in in the disabilities tabs now.
There's also a skills category that we have but it's effectively the same as feats.

Why

I figured, it's better to sort it earlier then later.

Changelog
🆑

  • tweak: Sorts the Traits into new categories.

Raikyr0 added 17 commits March 15, 2026 13:42
Signed-off-by: Raikyr0 <Kurohana@hotmail.com.au>
Signed-off-by: Raikyr0 <Kurohana@hotmail.com.au>
Signed-off-by: Raikyr0 <Kurohana@hotmail.com.au>
Signed-off-by: Raikyr0 <Kurohana@hotmail.com.au>
Signed-off-by: Raikyr0 <Kurohana@hotmail.com.au>
Signed-off-by: Raikyr0 <Kurohana@hotmail.com.au>
Signed-off-by: Raikyr0 <Kurohana@hotmail.com.au>
Signed-off-by: Raikyr0 <Kurohana@hotmail.com.au>
Signed-off-by: Raikyr0 <Kurohana@hotmail.com.au>
Signed-off-by: Raikyr0 <Kurohana@hotmail.com.au>
Signed-off-by: Raikyr0 <Kurohana@hotmail.com.au>
Signed-off-by: Raikyr0 <Kurohana@hotmail.com.au>
Signed-off-by: Raikyr0 <Kurohana@hotmail.com.au>
Signed-off-by: Raikyr0 <Kurohana@hotmail.com.au>
Signed-off-by: Raikyr0 <Kurohana@hotmail.com.au>
Signed-off-by: Raikyr0 <Kurohana@hotmail.com.au>
Raikyr0 added 6 commits March 15, 2026 19:53
Signed-off-by: Raikyr0 <Kurohana@hotmail.com.au>
Signed-off-by: Raikyr0 <Kurohana@hotmail.com.au>
Signed-off-by: Raikyr0 <Kurohana@hotmail.com.au>
Signed-off-by: Raikyr0 <Kurohana@hotmail.com.au>
Signed-off-by: Raikyr0 <Kurohana@hotmail.com.au>
Signed-off-by: Raikyr0 <Kurohana@hotmail.com.au>
Signed-off-by: Raikyr0 <Kurohana@hotmail.com.au>
Copy link
Collaborator

@Mnemotechnician Mnemotechnician left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks fine, but changes to upstream files need to be commented.

Raikyr0 and others added 4 commits March 16, 2026 04:27
Co-authored-by: Mnemotechnican <69920617+Mnemotechnician@users.noreply.github.com>
Signed-off-by: Raikyr0 <Kurohana@hotmail.com.au>
Signed-off-by: Raikyr0 <Kurohana@hotmail.com.au>
Signed-off-by: Raikyr0 <Kurohana@hotmail.com.au>
Signed-off-by: Raikyr0 <Kurohana@hotmail.com.au>
@Cprn-Sprkl
Copy link
Contributor

While we're changing the category names it might be a good idea to drop "disability" from the names completely. Just have Physical and Mental alongside the other categories. Especially since the old Mental category got replaced completely.

@Raikyr0
Copy link
Contributor Author

Raikyr0 commented Mar 15, 2026

While we're changing the category names it might be a good idea to drop "disability" from the names completely. Just have Physical and Mental alongside the other categories. Especially since the old Mental category got replaced completely.

So, there's a few reasons why I have it set up like this.
First, it separates disabilities which give you more points from buffs which cost points.
Second, I'm not sure how the load order for traits works yet, so I have the ones that give points at the top and ones that use points at the bottom.
Feats/Skills are typically generic or unusual perks, altho I plan on having a biological category which have organ replacements and such. But for now those exist in feats. Like Dwarf Livers and Vampirism.

@Raikyr0 Raikyr0 requested a review from Mnemotechnician March 16, 2026 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants