Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roster selection #611

Draft
wants to merge 23 commits into
base: main
Choose a base branch
from
Draft

Roster selection #611

wants to merge 23 commits into from

Conversation

g3rg
Copy link
Collaborator

@g3rg g3rg commented Oct 19, 2021

Detect and display roster from BattleScribe file. Allow selecting / deselecting of operatives, which in turn hides the data cards.

@lstrzebinczyk
Copy link
Collaborator

@g3rg Since the PR is in draft mode, is it not finished yet? Should I wait with reviewing?

@g3rg
Copy link
Collaborator Author

g3rg commented Oct 19, 2021

@g3rg Since the PR is in draft mode, is it not finished yet? Should I wait with reviewing?

I'm keen to get the review, but not just of the code, also around usability / usefulness. For printing data cards the roster selection is useful, however with how roster files work in Battlescribe, there's no equipment or fireteam/archetype information, so I guess I'm also asking if this should be merged/deployed before it is determined how that should work.

@g3rg
Copy link
Collaborator Author

g3rg commented Oct 20, 2021

Looks like some of the latest dependency bumps or lint related changes may have broken the tests.

@Floppy
Copy link
Owner

Floppy commented Oct 20, 2021

Yeah, think this is my fault. I'll get main green today.

@Floppy
Copy link
Owner

Floppy commented Oct 20, 2021

OK, main is green now, if you rebase then that should solve the test failures. Sorry about that!

@lstrzebinczyk
Copy link
Collaborator

Ok, I had a chance to open and run this finally. It's not a feature I'd be using. I am not quite sure what's the idea behind it, so I'm unsure what advice I can give 🤔

As a person who would not use it I'd make it opt-in. Make it only show after checking a checkbox in settings, perhaps?

@g3rg
Copy link
Collaborator Author

g3rg commented Oct 21, 2021

Ok, I had a chance to open and run this finally. It's not a feature I'd be using. I am not quite sure what's the idea behind it, so I'm unsure what advice I can give 🤔

As a person who would not use it I'd make it opt-in. Make it only show after checking a checkbox in settings, perhaps?

The eventual idea would be have your 20 model roster, then be able to select fireteams, then the models, then equipment. But as mentioned, that will be a bit of a change for dataslate to have more and more of the KT rules built in. I'm happy to put a setting in to turn it on, especially when in a WIP state, though it also only shows when you build a roster in Battlescribe, as opposed to actual kill team.

…en removing / adding operatives of the same type
@g3rg
Copy link
Collaborator Author

g3rg commented Oct 30, 2021

As per the discord discussion, I'll leave this as draft, and continue working on it in the background till its useable and useful. No need to review, though comments on how it might work are appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants