Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ingress tls entry #94

Closed
wants to merge 2 commits into from
Closed

Add support for ingress tls entry #94

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dfbd24f
Add support for ingress tls entry
hardillb Jul 12, 2023
634acc1
Add secret name
hardillb Jul 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions kubernetes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,6 +343,14 @@ const createIngress = async (project, options) => {
localIngress.spec.rules[0].host = url.host
localIngress.spec.rules[0].http.paths[0].backend.service.name = `${prefix}${project.safeName}`

if (url.protocol === 'https') {
localIngress.spec.tls = [{
hosts: [
url.host
]
}]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

secretName: "ff-apps-ca-secret"

Or something, to hold the wildcard ca certificate to be used for applications, would need to be documented.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ff-apps-ca-secrets is not a Secret, it's a collection of CA certs that the instance should trust, so not useful here.

I'm still working out how to solve this nicely, there are 2 possible approaches

  1. A single shared wildcard cert/key in a single secret
  2. A secret per instance, and something like CertManager issuing new ACME provisioned certs for each.

Both have pros/cons for different environments.

}

return localIngress
}

Expand Down