Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a devices/:deviceId/history API endpoint #5090

Merged
merged 8 commits into from
Feb 11, 2025

Conversation

cstns
Copy link
Contributor

@cstns cstns commented Feb 7, 2025

Description

Add a devices/:deviceId/history API endpoint and alter the existing project history auditLog model to query devices as well

Related Issue(s)

part of #4873

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

…tory auditLog model to query devices as well
@cstns cstns self-assigned this Feb 7, 2025
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 84.09091% with 7 lines in your changes missing coverage. Please review.

Project coverage is 78.42%. Comparing base (d5a6a96) to head (f1ccab4).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
forge/routes/api/shared/device.js 63.15% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5090      +/-   ##
==========================================
- Coverage   78.42%   78.42%   -0.01%     
==========================================
  Files         331      331              
  Lines       15544    15543       -1     
  Branches     3593     3593              
==========================================
- Hits        12190    12189       -1     
  Misses       3354     3354              
Flag Coverage Δ
backend 78.42% <84.09%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@knolleary knolleary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to add a separate feature flag for this as there is no scenario where a team would have history for local instances and not remote instances. The existing projectHistory flag should be reused.

@cstns cstns requested a review from knolleary February 11, 2025 13:38
@cstns cstns merged commit 66f12f7 into main Feb 11, 2025
21 checks passed
@cstns cstns deleted the version-history-for-devices-api branch February 11, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants