Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add externalBroker feature flag to UI #5100

Merged
merged 7 commits into from
Feb 11, 2025
Merged

Conversation

knolleary
Copy link
Member

Add feature-flag guards in the UI to not show external broker options if flag not set.

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.26%. Comparing base (d14ce19) to head (cb726fb).
Report is 8 commits behind head on 3rd-party-broker.

Additional details and impacted files
@@                Coverage Diff                @@
##           3rd-party-broker    #5100   +/-   ##
=================================================
  Coverage             78.26%   78.26%           
=================================================
  Files                   337      337           
  Lines                 15865    15865           
  Branches               3664     3664           
=================================================
  Hits                  12416    12416           
  Misses                 3449     3449           
Flag Coverage Δ
backend 78.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cstns
Copy link
Contributor

cstns commented Feb 11, 2025

added #5103 as a follow-up

@cstns cstns requested a review from hardillb February 11, 2025 14:46
@cstns cstns self-assigned this Feb 11, 2025
@cstns cstns marked this pull request as ready for review February 11, 2025 14:46
Base automatically changed from mqtt-topic-schema-storge to 3rd-party-broker February 11, 2025 15:05
@hardillb hardillb merged commit 3fe9f9f into 3rd-party-broker Feb 11, 2025
20 checks passed
@hardillb hardillb deleted the update-broker-guards branch February 11, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants