FIX #2617 Cherio Web Crawler doesn't work with large sites #2678
+8
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
do you have an example site that we can test before and after this PR? |
|
Sure, I tested on this site: https://www.cupraofficial.pl. It takes about 10 minutes to scrap everything and upload to Postgres VectorDB. |
HenryHengZJ
reviewed
Jun 21, 2024
| } | ||
| if (process.env.DEBUG === 'true') options.logger.info(`Finish ${relativeLinksMethod}`) | ||
| } else if (selectedLinks && selectedLinks.length > 0) { | ||
| if (process.env.DEBUG === 'true') | ||
| options.logger.info(`pages: ${JSON.stringify(selectedLinks)}, length: ${selectedLinks.length}`) | ||
| for (const page of selectedLinks.slice(0, limit)) { | ||
| docs.push(...(await cheerioLoader(page))) | ||
| docs.push(...((await cheerioLoader(page)) || [])) |
There was a problem hiding this comment.
instead of placing the [], I think we should just modify the cheerioLoader function to return [] when catch (err)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
There is a fix for issue #2617. There were two problems.
Firstly, sometimes cheerioLoader fails to download contnent of page and it returns undefined, so I added assignment of empty arrays if there is undefined.
Secondly, CheerioWebBaseLoader doesn’t support loading PDF files. It takes a lot to load PDF file and the content is encoded so I believe it shouldn’t be downloaded as Document. So I added condition to avoid downloading PDF files.
I’ve tried it on the same Chatflow as in the issue.