Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix llm instanceof wrong ChatOpenAI type #2726

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mokeyish
Copy link
Contributor

@mokeyish mokeyish commented Jun 26, 2024

update

import { ChatOpenAI } from '../../chatmodels/ChatOpenAI/FlowiseChatOpenAI'

to

import { ChatOpenAI } from '@langchain/openai'

@HenryHengZJ
Copy link
Contributor

it is the correct import, FlowiseChatOpenAI is needed for multiModalOption

@mokeyish
Copy link
Contributor Author

it is the correct import, FlowiseChatOpenAI is needed for multiModalOption

I see that the actual instance of llm is LanhchainChatOpenAI. Should logical OR be used here?

@HenryHengZJ
Copy link
Contributor

it is the correct import, FlowiseChatOpenAI is needed for multiModalOption

I see that the actual instance of llm is LanhchainChatOpenAI. Should logical OR be used here?

which line?

@mokeyish
Copy link
Contributor Author

it is the correct import, FlowiseChatOpenAI is needed for multiModalOption

I see that the actual instance of llm is LanhchainChatOpenAI. Should logical OR be used here?

which line?

} else if (llm instanceof ChatOpenAI) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants