Merge pull request #31 from Flowpack/task-add-url-logging-in-node-ren…

…derer-orchestrator TASK: Add URL logging to NodeRendererOrchestrator
Flowpack · Jul 11, 2023 · 6adb8e0 · 6adb8e0
2 parents f75bdb8 + 92cca46
commit 6adb8e0
Showing 1 changed file with 10 additions and 3 deletions.
diff --git a/Classes/NodeRendering/NodeRenderOrchestrator.php b/Classes/NodeRendering/NodeRenderOrchestrator.php
@@ -158,19 +158,26 @@ public function renderContentRelease(ContentReleaseIdentifier $contentReleaseIde
 
                 $renderedDocumentFromContentCache = $this->redisContentCacheReader->tryToExtractRenderingForEnumeratedNodeFromContentCache(DocumentNodeCacheKey::fromEnumeratedNode($enumeratedNode));
                 if ($renderedDocumentFromContentCache->isComplete()) {
-                    $contentReleaseLogger->debug('Node fully rendered, adding to content release', ['node' => $enumeratedNode]);
+                    $contentReleaseLogger->debug(
+                        'Node fully rendered, adding to content release',
+                        ['url' => $renderedDocumentFromContentCache->getUrl(), 'node' => $enumeratedNode]
+                    );
                     // NOTE: Eventually consistent (TODO describe)
                     // If wanted more fully consistent, move to bottom....
                     $this->nodeRenderingExtensionManager->addRenderedDocumentToContentRelease($contentReleaseIdentifier, $renderedDocumentFromContentCache, $contentReleaseLogger);
                 } else {
-                    $contentReleaseLogger->debug('Scheduling rendering for Node, as it was not found or its content is incomplete: ' . $renderedDocumentFromContentCache->getIncompleteReason(), ['node' => $enumeratedNode]);
+                    $contentReleaseLogger->debug(
+                        'Scheduling rendering for Node, as it was not found or its content is incomplete: '
+                        . $renderedDocumentFromContentCache->getIncompleteReason(),
+                        ['url' => $renderedDocumentFromContentCache->getUrl(), 'node' => $enumeratedNode]
+                    );
                     // the rendered document was not found, or has holes. so we need to re-render.
                     $nodesScheduledForRendering[] = $enumeratedNode;
                     $this->redisRenderingQueue->appendRenderingJob($contentReleaseIdentifier, $enumeratedNode);
                 }
             }
 
-            if (count($nodesScheduledForRendering) === 0) {
+            if (empty($nodesScheduledForRendering)) {
                 // we have NO nodes scheduled for rendering anymore, so that means we FINISHED successfully.
                 $contentReleaseLogger->info('Everything rendered completely. Finishing RenderOrchestrator');