Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUGFIX: Prevent division by zero in sparkline rendering #39

Merged
merged 1 commit into from
Mar 12, 2025
Merged

BUGFIX: Prevent division by zero in sparkline rendering #39

merged 1 commit into from
Mar 12, 2025

Conversation

JamesAlias
Copy link
Contributor

@JamesAlias JamesAlias commented Jan 22, 2025 •
edited
Loading

This happens in odd cases. I think crashing the whole ContentRelease because of a sparkline error doesn't help.

If max === 0 we just render a 0 value.

@JamesAlias JamesAlias self-assigned this Jan 22, 2025
skurfuerst
skurfuerst approved these changes Mar 5, 2025
View reviewed changes
Copy link
Contributor

@skurfuerst skurfuerst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like :)

@JamesAlias JamesAlias merged commit 2fb304c into main Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skurfuerst skurfuerst skurfuerst approved these changes

Assignees

@JamesAlias JamesAlias

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JamesAlias @skurfuerst