Merge pull request #42 from simstern/bugfix/maximumNumberOfReleases-d…

…efault BUGFIX: maximumNumberOfReleases default value
Flowpack · Feb 24, 2020 · c6efb27 · c6efb27
2 parents 84094bc + 9a16216
commit c6efb27
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/Classes/Job/JobManager.php b/Classes/Job/JobManager.php
@@ -27,6 +27,11 @@
  */
 class JobManager
 {
+    /**
+     * @var int
+     */
+    const DEFAULT_MAXIMUM_NUMBER_RELEASES = 3;
+
     /**
      * @Flow\Inject
      * @var QueueManager
@@ -108,7 +113,9 @@ public function waitAndExecute(string $queueName, $timeout = null): ?Message
                 $this->executeJobForMessage($queue, $message);
             }
         } catch (\Exception $exception) {
-            $maximumNumberOfReleases = isset($queueSettings['maximumNumberOfReleases']) ? (integer)$queueSettings['maximumNumberOfReleases'] : 0;
+            $maximumNumberOfReleases = isset($queueSettings['maximumNumberOfReleases']) ?
+                (int)$queueSettings['maximumNumberOfReleases'] :
+                self::DEFAULT_MAXIMUM_NUMBER_RELEASES;
             if ($message->getNumberOfReleases() < $maximumNumberOfReleases) {
                 $releaseOptions = isset($queueSettings['releaseOptions']) ? $queueSettings['releaseOptions'] : [];
                 $queue->release($message->getIdentifier(), $releaseOptions);