Fix sub-minute countdown display, add hook test coverage, fix Lighthouse env var - #322
Closed
yosemite01 wants to merge 1 commit into
Closed
Fix sub-minute countdown display, add hook test coverage, fix Lighthouse env var#322yosemite01 wants to merge 1 commit into
yosemite01 wants to merge 1 commit into
Conversation
… var - lib/stream-utils.ts: only render the minutes segment in formatTimeRemaining when minutes>0 or a larger unit is present, so sub-minute durations show "45s" instead of "0m 45s" (#291) - __tests__/hooks/: add unit tests for previously untested hooks (use-wallet, use-webhooks, use-token-price, use-activity-feed, use-form-draft, use-stream-history, use-show-usd, useBulkActions, useBulkSelect, useNotifications) (#295) - .github/workflows/lighthouse.yml: also pass NEXT_PUBLIC_STREAM_CONTRACT_ID_MAINNET at build time alongside the existing _TESTNET var, matching what lib/stellar.ts reads (#303) Closes #291 Closes #295 Closes #303
Contributor
Author
|
Superseded by #323, opened from the correct account. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #291
Closes #295
Closes #302
Closes #303
#291 — sub-minute countdown showing "0m 45s"
formatTimeRemaininginlib/stream-utils.tsnow only emits the minutes segment whenminutes > 0or a larger unit (hours) is already present, matching the existing pattern used for thedayscheck. Sub-minute countdowns now read45sinstead of0m 45s.#295 — hook test coverage
Added unit tests under
__tests__/hooks/for the previously untested hooks:use-wallet,use-webhooks,use-token-price(+usePortfolioValue/formatUsd),use-activity-feed,use-form-draft(+clearExpiredDrafts),use-stream-history,use-show-usd,useBulkActions,useBulkSelect, anduseNotifications, following the mocking conventions already used inuse-contract.test.ts/use-streams.test.ts. (use-contract,use-auto-withdraw, anduse-notificationsalready had coverage.)#302 — e2e Playwright tests never run in CI
Verified this is already resolved on
main(see.github/workflows/ci.yml'se2ejob, added in0adc415) — it installs Playwright browsers and runsnpx playwright teston every push/PR tomain. Closing as already addressed.#303 — Lighthouse CI env var
.github/workflows/lighthouse.ymlalready setNEXT_PUBLIC_STREAM_CONTRACT_ID_TESTNET(matchinglib/stellar.ts's default testnet read path), but was missing the_MAINNETcounterpart. AddedNEXT_PUBLIC_STREAM_CONTRACT_ID_MAINNETto the build step's env so both network variants are covered.