[BUGFIX] Fix flux content record not being overlayed properly inside active workspaces #2253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Information to add: The issue prominently appeared when trying to view a workspace record of a translation. |
|
@NamelessCoder Could we get this PR reviewed and the workflow approved? |
Rall3n
force-pushed
the
fix-l18n-workspace-overlay
branch
from
c2e496d to
03c951f
Compare
Rall3n
force-pushed
the
fix-l18n-workspace-overlay
branch
from
03c951f to
3ce44da
Compare
NamelessCoder
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2177
When trying to fetch singular records using
WorkspacesAwareRecordService->getSingle, the records were not properly overlayed with data from workspace records.This PR fixes that by properly using the return value of
WorkspacesAwareRecordService->overlayRecordInternalwhich was assumed to be pass-by-reference.