fix: フォーマット #280
Merged
fix: フォーマット #280
+835
−540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
website
YumNumm
approved these changes
Sep 29, 2024
Comment on lines
+9
to
+10
| exclude: | ||
| - lib/gen/i18n/strings.g.dart |
| @@ -49,7 +49,7 @@ scripts: | |||
| dependsOn: custom_lint | |||
|
|
|||
| rebuild: | |||
| run: dart run build_runner build -d | |||
| run: dart run build_runner build -d && melos format -c 5 | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
なし
説明
以前、slang で自動生成されたコードがフォーマットされない問題が発覚しました。
slang-i18n/slang#184
そのため melos format コマンドで毎回余計な差分が発生してしまうため CI で melos format コマンドによるチェックができない状況でした。
melos run rebuild コマンドで必ず melos format すればいいと考えましたが、そうすると string.g.dart ファイル内でクラス内の変数を使っていないという警告が出るようになってしまいました。
そのため、いったん苦肉の策として analyzer から 18n/string.g.dart を除外するようにしました。
画像 / 動画
見た目の変更なし。
その他