Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix two bugs re setup #2145

Merged
merged 1 commit into from
Dec 28, 2022
Merged

Fix two bugs re setup #2145

merged 1 commit into from
Dec 28, 2022

Conversation

mcabbott
Copy link
Member

Fixes #2144, and a bug found in FluxML/model-zoo#374

@codecov-commenter
Copy link

codecov-commenter commented Dec 28, 2022

Codecov Report

Base: 86.81% // Head: 84.19% // Decreases project coverage by -2.61% ⚠️

Coverage data is based on head (b5d9a89) compared to base (ba48ad0).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2145      +/-   ##
==========================================
- Coverage   86.81%   84.19%   -2.62%     
==========================================
  Files          19       19              
  Lines        1471     1468       -3     
==========================================
- Hits         1277     1236      -41     
- Misses        194      232      +38     
Impacted Files Coverage Δ
src/deprecations.jl 51.61% <100.00%> (+3.22%) ⬆️
src/train.jl 96.00% <100.00%> (ø)
src/cuda/cudnn.jl 0.00% <0.00%> (-90.91%) ⬇️
src/functor.jl 42.10% <0.00%> (-46.04%) ⬇️
src/layers/normalise.jl 86.66% <0.00%> (-2.43%) ⬇️
src/layers/conv.jl 87.93% <0.00%> (-0.07%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mcabbott mcabbott merged commit 4da339e into FluxML:master Dec 28, 2022
@mcabbott mcabbott deleted the setup2 branch December 28, 2022 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Method error when using Flux.setup with Embedding layer
3 participants