rework cmake v2 #312
Open
rework cmake v2 #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit cc01c67.
Windows doesn't usually use lib prefix
|
Sorry for the hassle, this is required for many applications bundled ryzenadj without libryzenadj.dll. Will squash some of your comments to keep git history clean. I'm actually thinking about migrate to meson build and deprecate CMake stuff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated #306
ryzenadj and lib are two artifacts now, this also makes clear ryzenadj is static (dll was uploaded in release, didn't even try to remove it, so thought it was dynamic) and i think this way is more correct and clean