This repository has been archived by the owner on Aug 18, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can you squash the two commits before I do any review? That way the commit log is clean for the commits which modify anything which needs to change. Edit for future clarity: The second commit redid all the work in the first so better to squash into one commit. |
Damage Indicators now work perfectly
ForLoveOfCats
suggested changes
Jul 30, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure to convert DamageIndicator.cs to use tab indentation
and of course if I said anything inaccurate please do correct me |
ForLoveOfCats
suggested changes
Jul 30, 2019
ForLoveOfCats
suggested changes
Aug 1, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You made the image yourself right?
Yes, I did make the image myself |
Added transparency shader. Made DamageIndicators last for longer depending on the power of the shot (currently 10 damage = 1 second)
…otation to the default one frame before it's removed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added damage indicators from issue #68