Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: action form can be a function #1146

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,13 @@ export default class ActionCollectionDecorator extends CollectionDecorator {
const context = this.getContext(caller, action, formValues, filter, used, metas?.changedField);

// Convert DynamicField to ActionField in successive steps.
let dynamicFields: DynamicField[] = action.form.map(c => ({ ...c }));
let dynamicFields: DynamicField[];

if (this.isHandler(action.form)) {
dynamicFields = (await action.form(context)).map(c => ({ ...c }));
} else {
dynamicFields = action.form.map(c => ({ ...c }));
}

if (metas?.searchField) {
// in the case of a search hook,
Expand Down Expand Up @@ -96,12 +102,18 @@ export default class ActionCollectionDecorator extends CollectionDecorator {
for (const [name, { form, scope, generateFile }] of Object.entries(this.actions)) {
// An action form can be send in the schema to avoid calling the load handler
// as long as there is nothing dynamic in it.
const isDynamic = form?.some(
field =>
Object.values(field).some(value => typeof value === 'function') ||
// A field with a hardcoded file should not be sent to the apimap. it is marked dynamic
(field.type.includes('File') && field.defaultValue),
);
let isDynamic = false;

if (this.isHandler(form)) {
isDynamic = true;
} else {
isDynamic = form?.some(
field =>
Object.values(field).some(value => typeof value === 'function') ||
// A field with a hardcoded file should not be sent to the apimap. it is marked dynamic
(field.type.includes('File') && field.defaultValue),
);
}

newSchema.actions[name] = { scope, generateFile: !!generateFile, staticForm: !isDynamic };
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,10 @@ export interface BaseAction<
> {
generateFile?: boolean;
scope: Scope;
form?: DynamicField<Context>[];
form?:
| DynamicField<Context>[]
| ((context: ActionContext<TSchema, string>) => DynamicField<Context>[])
| ((context: ActionContext<TSchema, string>) => Promise<DynamicField<Context>[]>);
execute(
context: Context,
resultBuilder: ResultBuilder,
Expand Down
Loading