feat(filter): add "is in" filter (#806)

ForestAdmin · Sep 10, 2021 · bb10856 · bb10856
1 parent e039498
commit bb10856
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/src/services/filters-parser.js b/src/services/filters-parser.js
@@ -94,7 +94,9 @@ function FiltersParser(modelSchema, timezone, options) {
       case 'includes_all':
         return { [this.OPERATORS.CONTAINS]: value };
       case 'in':
-        return { [this.OPERATORS.IN]: value };
+        return typeof value === 'string'
+          ? { [this.OPERATORS.IN]: value.split(',').map((elem) => elem.trim()) }
+          : { [this.OPERATORS.IN]: value };
       default:
         throw new NoMatchingOperatorError();
     }

diff --git a/test/services/filters-parser.test.js b/test/services/filters-parser.test.js
@@ -88,7 +88,7 @@ describe('services > filters-parser', () => {
   });
 
   describe('formatOperatorValue function', () => {
-    const values = [5, 'toto', null];
+    const values = [5, 'toto,tutu ', null];
 
     values.forEach((value) => {
       it(`should return the appropriate value (${typeof value})`, () => {
@@ -113,7 +113,11 @@ describe('services > filters-parser', () => {
             [OPERATORS.EQ]: '',
           }],
         });
-        expect(defaultFiltersParser.formatOperatorValue('in', value)).toStrictEqual({ [OPERATORS.IN]: value });
+        expect(defaultFiltersParser.formatOperatorValue('in', value)).toStrictEqual(
+          typeof value === 'string'
+            ? { [OPERATORS.IN]: value.split(',').map((elem) => elem.trim()) }
+            : { [OPERATORS.IN]: value },
+        );
       });
 
       it('should raise an error on unknown operator', () => {