fix: return data of field who have the same name as model (#880)

ForestAdmin · Jan 31, 2022 · cee9327 · cee9327
1 parent fd0b4e0
commit cee9327
Show file tree

Hide file tree

Showing 2 changed files with 67 additions and 2 deletions.
diff --git a/src/services/requested-fields-extractor.js b/src/services/requested-fields-extractor.js
@@ -61,8 +61,10 @@ function extractRequestedFields(requestedFields, modelOrAssociation, schemas) {
     ))
     .flat();
 
-  const modelFields = requestedFields[modelOrAssociation.name].split(',')
-    .filter((fieldName) => !requestedFields[fieldName]);
+  const modelFields = requestedFields[modelOrAssociation.name]
+    .split(',')
+    .filter((fieldName) =>
+      Object.prototype.hasOwnProperty.call(modelOrAssociation.rawAttributes, fieldName));
 
   const smartFields = extractRequestedSmartField(requestedFields, schemas[modelOrAssociation.name]);
 

diff --git a/test/services/requested-fields-extractor.test.js b/test/services/requested-fields-extractor.test.js
@@ -23,6 +23,11 @@ describe('services > requested-fields-extractor', () => {
       name: 'user',
       primaryKeys: { id: null, uid: null },
       associations: {},
+      rawAttributes: {
+        id: {},
+        uid: {},
+        name: {},
+      },
     };
 
     const schemas = {
@@ -51,6 +56,11 @@ describe('services > requested-fields-extractor', () => {
       name: 'user',
       primaryKeys: { id: null, uid: null },
       associations: {},
+      rawAttributes: {
+        id: {},
+        uid: {},
+        name: {},
+      },
     };
 
     const schemas = {
@@ -68,6 +78,38 @@ describe('services > requested-fields-extractor', () => {
     expect(result).toStrictEqual(['id', 'name']);
   });
 
+  it('should include field with same name as the model', () => {
+    expect.assertions(1);
+
+    const fields = {
+      user: 'id,user',
+    };
+
+    const model = {
+      name: 'user',
+      primaryKeys: { id: null },
+      associations: {},
+      rawAttributes: {
+        id: {},
+        user: {},
+      },
+    };
+
+    const schemas = {
+      user: {
+        name: 'user',
+        fields: [{
+          field: 'user',
+          isVirtual: false,
+        }],
+      },
+    };
+
+    const result = extractRequestedFields(fields, model, schemas);
+
+    expect(result).toStrictEqual(['id', 'user']);
+  });
+
   it('should include all associations\' requested fields', () => {
     expect.assertions(1);
 
@@ -87,6 +129,11 @@ describe('services > requested-fields-extractor', () => {
           },
         },
       },
+      rawAttributes: {
+        id: {},
+        uid: {},
+        name: {},
+      },
     };
 
     const schemas = {
@@ -130,6 +177,12 @@ describe('services > requested-fields-extractor', () => {
           },
         },
       },
+      rawAttributes: {
+        id: {},
+        uid: {},
+        name: {},
+        account: {},
+      },
     };
 
     const schemas = {
@@ -180,6 +233,12 @@ describe('services > requested-fields-extractor', () => {
           },
         },
       },
+      rawAttributes: {
+        id: {},
+        uid: {},
+        name: {},
+        account: {},
+      },
     };
 
     const schemas = {
@@ -222,6 +281,10 @@ describe('services > requested-fields-extractor', () => {
       name: 'user',
       primaryKeys: { id: null, uid: null },
       associations: {},
+      rawAttributes: {
+        id: {},
+        uid: {},
+      },
     };
 
     const schemas = {