Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][FIX] rma_account: reconcile GDNI when receiving but refund is not expected #360

Merged
merged 2 commits into from
Jan 6, 2023

Conversation

AaronHForgeFlow
Copy link
Contributor

Tries to fix:
#356

@JordiBForgeFlow
Copy link
Contributor

Perhaps the refund wizard should have boolean 'free of charge'.

Then, in the operation you could define that an automated refund, should be created after recepit, for the quantities received. In the operation I would distinguish two booleans:

  • Automated refund
  • Free of charge refund

@AaronHForgeFlow AaronHForgeFlow force-pushed the 14.0-fix-rma_account-gdni-when-replace branch from ead3d1e to 6d3dbb3 Compare January 4, 2023 11:44
@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2023

Codecov Report

Merging #360 (6d3dbb3) into 14.0 (7e497ab) will increase coverage by 0.02%.
The diff coverage is 78.78%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             14.0     #360      +/-   ##
==========================================
+ Coverage   80.04%   80.07%   +0.02%     
==========================================
  Files         138      138              
  Lines        4505     4536      +31     
  Branches      846      853       +7     
==========================================
+ Hits         3606     3632      +26     
- Misses        695      698       +3     
- Partials      204      206       +2     
Impacted Files Coverage Δ
rma_account/wizards/rma_refund.py 83.49% <0.00%> (ø)
rma_account/models/rma_operation.py 58.82% <50.00%> (-4.82%) ⬇️
rma_account/models/rma_order_line.py 73.64% <84.61%> (+1.05%) ⬆️
rma_account/models/stock_move.py 88.88% <100.00%> (+1.38%) ⬆️
rma_account/tests/test_rma_stock_account.py 99.34% <100.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e497ab...6d3dbb3. Read the comment docs.

@AaronHForgeFlow
Copy link
Contributor Author

Well, I have included the two booleans, but basically, the refund_free_of_charge boolean will always be True when the user marks the bollean "automated_refund". I am not sure if that is going to be used in any other sceneraio, but it is there just in case.

@JordiBForgeFlow JordiBForgeFlow merged commit da1ff3c into 14.0 Jan 6, 2023
@LoisRForgeFlow LoisRForgeFlow deleted the 14.0-fix-rma_account-gdni-when-replace branch January 9, 2023 14:41
@LoisRForgeFlow
Copy link
Contributor

@AaronHForgeFlow could you forward port this?

@LoisRForgeFlow
Copy link
Contributor

ping @AaronHForgeFlow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants