Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] RMA #558

Open
wants to merge 200 commits into
base: 18.0
Choose a base branch
from
Open

[18.0][MIG] RMA #558

wants to merge 200 commits into from

Conversation

JasminSForgeFlow
Copy link
Collaborator

@JasminSForgeFlow JasminSForgeFlow commented Nov 27, 2024

@LoisRForgeFlow
Copy link
Contributor

@JasminSForgeFlow Is this #572 included here?

@JasminSForgeFlow
Copy link
Collaborator Author

@JasminSForgeFlow Is this #572 included here?

Yes, it was changed already

Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @JasminSForgeFlow

An alignment of versions has been done in v17 #577. Could you take of aligning 17 and 18 again here?

Apart from that PR, there is potentially some others that were merged in 17 after this migration was created:

image

Please, make sure to leave anything behind.

cc @DavidJForgeFlow

JordiBForgeFlow and others added 23 commits February 18, 2025 12:29
* fix assignment of moves.
* default qty in rma lines.
* remove account dependency.
* test and flake8 fixes.
… supplier

[IMP]Separate menus for customer and supplier operations
* Add active field to rma operation
* Added tests
* Fix travis
* Fix create supplier rma from customer rma
* rma: receipt_policy selections not matching.
* rma_sale: fix _prepare_rma_line_from_sale_order_line.
* remove unneded copy attributes.
* simplify action_view methods.
* fix wrong naming.
* fix misplaced views.
* fix wrong count and view actions for rma.orders in invoices.
* fix error when installing the module.
* remove unneded data update when preparing rma lines from invoice lines.
* minor extra fixes.
* remove unneded copy and ondelete attributes.
* simplify action_view methods.
* fix rma line supplier view.
* fix wizard.
* extend README.
* minor extra fixes.
AaronHForgeFlow and others added 25 commits February 18, 2025 12:29
qty_done -> quantity
reserved_qty field does no exist anymore
When returning or delivering a serial product from a RMA, we will calculate by default its package. Later, it can be modyfied by the user.
When looking at stock moves created from a rma group, it may be confusing knowing who's move is for which RMA line. This improvement should avoid these confusions.
When canceling a rma order line, it will also cancel the previous (orig) steps.
Following steps (dest) can be managed with the propagate cancel option of the stock rules.
This commit also avoid canceling a whole picking which is problematic in case of the use of RMA groups
Avoid reserving units that are not available. Also ensures the lot picked is the correct one by adding a dependency to stock_move_forced_lot.
The two modules have the same features, but the stock_restrict_lot is more used in other modules so changing the module used to match the OCA behavior.
…n/expedition

Now the moves are filtered and only 1 move of the chain is selected to compute the quantity (the first one for reception and last one for expedition), so we should no longer ignore those to compute the quantities
@DavidJForgeFlow
Copy link
Contributor

DavidJForgeFlow commented Feb 19, 2025

Hi @JasminSForgeFlow could you also add #563, #550 and #555? 748d01939bcf6374605da1f3e95a6bd8e6b4f9e2
4ad1c3865e4e1417d6dead03c8c4be57f9b10765
28174e49a9018f429136eebd2a3815068624143b

@LoisRForgeFlow
Copy link
Contributor

One more #590 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.