Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][FIX] rma: stock manager should not inherit rma manager permissions, that group must be explicity added #592

Open
wants to merge 2 commits into
base: 17.0
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions rma/security/rma.xml
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,6 @@
<field name="category_id" ref="module_category_rma" />
</record>

<record id="stock.group_stock_manager" model="res.groups">
<field name="implied_ids" eval="[(4, ref('group_rma_manager'))]" />
</record>

<record model="ir.rule" id="rma_order_rule">
<field name="name">rma order multi-company</field>
<field
Expand Down
2 changes: 1 addition & 1 deletion rma_reason_code/README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ Authors
Contributors
------------

- David Jiménez <[email protected]>
- David Jiménez <[email protected]>

Maintainers
-----------
Expand Down
7 changes: 3 additions & 4 deletions rma_reason_code/static/description/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,10 @@

/*
:Author: David Goodger ([email protected])
:Id: $Id: html4css1.css 9511 2024-01-13 09:50:07Z milde $
:Id: $Id: html4css1.css 8954 2022-01-20 10:10:25Z milde $
:Copyright: This stylesheet has been placed in the public domain.

Default cascading style sheet for the HTML output of Docutils.
Despite the name, some widely supported CSS2 features are used.

See https://docutils.sourceforge.io/docs/howto/html-stylesheets.html for how to
customize this style sheet.
Expand Down Expand Up @@ -275,7 +274,7 @@
margin-left: 2em ;
margin-right: 2em }

pre.code .ln { color: gray; } /* line numbers */
pre.code .ln { color: grey; } /* line numbers */
pre.code, code { background-color: #eeeeee }
pre.code .comment, code .comment { color: #5C6576 }
pre.code .keyword, code .keyword { color: #3B0D06; font-weight: bold }
Expand All @@ -301,7 +300,7 @@
span.pre {
white-space: pre }

span.problematic, pre.problematic {
span.problematic {
color: red }

span.section-subtitle {
Expand Down
2 changes: 2 additions & 0 deletions rma_reason_code/tests/test_scrap_reason_code.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ class RMAOrderLine(common.TransactionCase):
def setUpClass(cls):
super().setUpClass()
cls.user_admin = cls.env.ref("base.user_admin")
rma_manager_group = cls.env.ref("rma.group_rma_manager")
cls.user_admin.write({"groups_id": [(4, rma_manager_group.id)]})
cls.env = api.Environment(cls.cr, cls.user_admin.id, {})
cls.user_admin.tz = False # Make sure there's no timezone in user
cls.warehouse = cls.env.ref("stock.warehouse0")
Expand Down
Loading