-
Notifications
You must be signed in to change notification settings - Fork 462
feat: Add a config plugin for Expo 53 with CNG #1086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Hi, @zibs – Not sure what else you want/need with regard to testing and documentation for this. Do you want me to add something to the README which explains how to configure the plugin (similar to the notes above)? Let me know and I'll be happy to do whatever you need. |
Thanks so much @Off2Race -- I'll take a look and be sure to let you know! |
- Add app.plugin.js entry point for Expo plugin discoverability - Fix plugin configuration transform to handle redirectUrls properly - Include plugin directory and entry point in npm package files - Ensure iOS and Android URL schemes are configured correctly from redirectUrls array
- having some issues with the expo-cng demo app and the workspace, so we remove it from the workspace entirely right now so it manages its own deps.
Thanks @Off2Race -- I've updated the code to use TypeScript and added an example app that supports this flow, as well as added the docs. Feel free to take a look and a double check that it looks okay, and if so, we can look towards merging and releasing!! Really appreciate everything you've done here. |
Awesome, @zibs! I'll look at it today. I should have realized that you'd want it in Typescript. My bad. Thanks for updating it. Back soon with feedback. |
Can I ask what the status is of this PR? Is this going to get merged? Anyway thanks for the effort both of you! |
Any news on the status of this PR? 😃 |
I think the best thing at this point would probably be just to merge and triage issues as they come up, albeit I have limited time to look at them atm. I'll try to get this released this month. |
Hi, @zibs. My apologies. I keep meaning to come back and test this and then something comes up. I agree with your suggestion. Release it when you can and then we can triage issues from there. I know the process works. I have 2 separate apps that use this plugin right now (albeit in another form). If your merged version has a problem, I can help troubleshoot. |
I've implemented the code from this branch locally and can confirm it
works. Though my native knowledge is minimal I can help if there's issues.
…On Tue, 14 Oct 2025, 17:25 Mike Loos, ***@***.***> wrote:
*Off2Race* left a comment (FormidableLabs/react-native-app-auth#1086)
<#1086 (comment)>
Hi, @zibs <https://github.com/zibs>. My apologies. I keep meaning to come
back and test this and then something comes up. I agree with your
suggestion. Release it when you can and then we can triage issues from
there. I know the process works. I have 2 separate apps that use this
plugin right now (albeit in another form). If your merged version has a
problem, I can help troubleshoot.
—
Reply to this email directly, view it on GitHub
<#1086 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHDPNKSYFEM2GQPTQUCVHA33XUIXPAVCNFSM6AAAAACEGEKUM6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTIMBSGQYTMNJTGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Description
Added an Expo config plugin so that react-native-app-auth can be used in an Expo 53-based project using CNG (Continuous Native Generation).
NOTE: The plugin will detect the current Expo version and should work with versions prior to 53 but that use case is not well-tested. For best results, stick with Expo 53.
Thanks to @aurelian for the original version that led to this.
Steps to verify
STEP 1
Add the plugin to the app's app.config.ts. See example below.
STEP 2
You'll likely need to add a
react-native-app-auth.d.ts
to the folder where you keep your Typescript types:STEP 3
Run
npx expo prebuild --clean