Fix c extension on python 3.12

Workaround for [1]. [1] python/cpython#103940 Signed-off-by: Sean Anderson <[email protected]>
Forty-Bot · Nov 19, 2023 · 8f76168 · 8f76168
1 parent 2a22a9f
commit 8f76168
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/atomic.h b/atomic.h
@@ -165,6 +165,10 @@ static int TYPE_ADD(PyObject *m)
 		return ret;
 	}
 
+	TYPE.tp_base = &BufferType;
+	if (PyType_Ready(&TYPE))
+		return -1;
+
 	if (PyType_AddSizeConstant(&TYPE, "size", sizeof(PTYPE)))
 		return -1;
 
@@ -192,7 +196,6 @@ static int TYPE_ADD(PyObject *m)
 #endif
 #endif
 
-	TYPE.tp_base = &BufferType;
 	Py_INCREF(&BufferType);
 	ret = PyModule_AddType(m, &TYPE);
 	Py_DECREF(&BufferType);

diff --git a/lock.c b/lock.c
@@ -217,14 +217,17 @@ int LockType_Add(PyObject *m)
 		return -1;
 	}
 
+	LockType.tp_base = &BufferType;
+	if (PyType_Ready(&LockType))
+		return -1;
+
 	if (PyType_AddSizeConstant(&LockType, "size", sizeof(pthread_mutex_t)))
 		return -1;
 
 	if (PyType_AddSizeConstant(&LockType, "align",
 				   alignof(pthread_mutex_t)))
 		return -1;
 
-	LockType.tp_base = &BufferType;
 	Py_INCREF(&BufferType);
 	err = PyModule_AddType(m, &LockType);
 	Py_DECREF(&BufferType);