fix app crash by saving minimalState on rotation #644

[jguegel]

Type of change(s)

• Bug fix
• Feature / enhancement
• Infrastructure / tooling (CI, build, deps, tests)
• Documentation

What changed and why

• fix app crash by saving minimalState on rotation

Tests performed

• tried rotation 20-30 times without crash (more seems to be unrealistic)

Closes the following issue(s)

• Closes App crashes after rotating several times #644

Checklist

• I read the contribution guidelines.
• I manually tested my changes on device/emulator (if applicable).
• I updated the "Unreleased" section in CHANGELOG.md (if applicable).
• I have self-reviewed my pull request (no typos, formatting errors, etc.).
• All checks are passing.

[naveensingh]

Not saving the state will hide the bug, not kill it. Always try to investigate and fix the root cause (e.g., figure out what's making the state so large that it crashes the app)

[jguegel]

The root cause is the saving of too many fragments:

• each fragment ~1256-1448 Bytes
• total 867.372 Bytes just for the fragments

A TransactionTooLargeException is thrown, because we are above the max 1MB TransactionLimit (together with all other transactions; but the fragments are by far the biggest amount).

Therefore i thought just saving the minimum into it, seemed to be a reasonable solution to at least "postpone" the bug to an unlikely amount of rotations.

[fossifybot]

This pull request was automatically closed due to inactivity and/or lack of response from the author. If you have further updates or additional information, please comment or reopen the PR to continue.