Old Man Ported #62
Merged
Old Man Ported #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
RSI Diff Bot; head commit 19842fb merging into 783a509 Resources/Textures/_SCP/Effects/oldmanpuddle.rsi
Resources/Textures/_SCP/Interface/Actions/oldman.rsi
Resources/Textures/_SCP/Mobs/Scps/oldman.rsi
|
gusxyz
reviewed
Oct 22, 2024
| //Die in pocket dimension | ||
| private void OnStateChange(EntityUid uid, PocketDimensionInhabitantComponent comp, MobStateChangedEvent args) | ||
| { | ||
| if (args.NewMobState == MobState.Critical || args.NewMobState == MobState.Dead) |
There was a problem hiding this comment.
Can you early return this if statement as well to keep in line with the rest of the code?
| //Dimension Setup | ||
| private void OnStartup(EntityUid owner, PocketDimensionHolderComponent comp, ComponentStartup args) | ||
| { | ||
| if (comp.pocketDimensionGrid == null) |
There was a problem hiding this comment.
could you early return? you do it in the next function. should be able to make it an if not.
|
linter aint happy 👎 |
github-actions
bot
added
the
Status: Merge Conflict
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
removed
the
Status: Merge Conflict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Known issue with no popup appearing if 106 attempts to create a teleport node within the pocket dimension
All sprites are placeholders
Incomplete Features
Resolves #54