Closed
Conversation
…otfix." This reverts commit ace7412.
…-backed servers (#31154) Fixed IP bans causing server errors with SQLite DB
* the shiny new toy that breaks everything else * privacy 😌 * janky shit * real?? ** ALL HAIL DUCT TAPE SOLUTION * FUCK * commented every shit
* add BankClientComponent and event * query BankClient instead of hardcoded CargoOrderConsole for updating * add BankClient to all ordering consoles *
* sort of works * fix * oh right * admin abuse * buy/sell events * price history, better error handling * joke * buying and selling * access handling * IT'S FINALLY REAL * fixes * AAAAAAAAAAAAAAAAA * i keep fucking forgetting things * FUCKING * move company structs out of the comp * ok im going to sleep * Revert "oh right" This reverts commit 8681e5a07b4d059fa7db718dd3ec6f25f0ad05d9. * Revert "fix" This reverts commit 3992ec99fd96dc7b2df0767e1b83d5418d86a248. * address reviews
… is radio-ed too (#31170) * feat: now when research is unlocked in console, approver of reasearch is radio-ed too * refactor: now most of events that require actor name to be radio-ed or logged use TryGetIdentityShortInfoEvent which is subscibed by id-card system and borg system (to work for both carbon and synthetic life-forms) * refactor: moved TryGetIdentityShortInfoEvent on id card system to shared, fixed cargo cent-com-originated orders * remove unused check * refactor: decoupled systems from IdCardSystem (those that are not dependent on it anymore) * refactor: removed unuseed usings * feat: emagged cargo/research consoles wont radio messages on buy/research confirm anymore --------- Co-authored-by: pa.pecherskij <pa.pecherskij@interfax.ru>
* Job title localization * Correcting fields
* Add events for player updating jobs * Add NoCaptainComponent * add and remove NoCaptainComponent logic * Gernalized to CaptainStateComponent * Generalized CaptainStateComponent * Add requesting aco vote * Add auto unlock aa * Remove hardcodecd strings * Add localization * // DeltaV * pro fix * fax cc please * move captain detection to CaptainStateSystem * track spareidsafe with comp instead * little bit of movement * fix broken formating Signed-off-by: SolStar <44028047+ewokswagger@users.noreply.github.com> * pls * Remove unused method * subscribe captainstatecomponent for job events * Cvars, Disabled AA on peri * temp fix for intergration test bug * :3 * format fix * spelling ops * nameing ops * done final real this time (1) (1) * remove has an out very nice --------- Signed-off-by: SolStar <44028047+ewokswagger@users.noreply.github.com>
* pass Actor to cartridge messages * NonSerialized gaming --------- Co-authored-by: deltanedas <@deltanedas:kde.org>
* more flatpacks + glass * solar crate price increase * price increase * 1250 spesos * Update Resources/Prototypes/Catalog/Fills/Crates/engines.yml --------- Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
# Description This PR adds a simple server configuration option for enabling basic "Soft-Crit", and not much else because oh my god this system is horribly complicated. When enabled, characters can crawl around very slowly while in crit, and really not much else. This more or less mirrors how crit affects character movement in SS13, where you can at least crawl to relative safety while bleeding to death. # Changelog :cl: - add: Added server config options for basic "Soft-Crit". When enabled, characters who are critically injured can still slowly crawl, but are otherwise still helpless and dying.
I'm not fully confident in this fix, I can't test it right now. closes #1409 1409 --------- Co-authored-by: Leon Friedrich <60421075+ElectroJr@users.noreply.github.com>
# Description Fixes notifications so that they always trigger when the chat is not open, fixes a possible exploit where a user can send a message that is longer than the max message length, and improves the UX of NanoChat in a few areas. Original message from Goob-Station/Goob-Station#1313: > Fixed NanoChat message notifications not showing up in situations where you'd definitely expect them to occur. > > Now, for a chat to not send a notification upon a new message, three conditions need to be fulfilled: > - You don't have the chat muted > - Your PDA UI is open > - You have NanoChat as your open program > - Your currently-selected chat is the aforementioned chat More changes: - Validate NanoChat message length & chat name/job title length on the server Goob-Station/Goob-Station@c063001. -If they are too long, they will be truncated to the maximum length. - Improve the UI for editing a chat: - Added a proper icon (used to be the letter E) for the Edit Chat button.  - The Edit Chat popup now has correct text: the title is now "Edit a contact", not "Add a new chat" and the Create button has been renamed to the Confirm button.  - Editing a chat no longer deselects the current chat. - This is done by adding a new NanoChatUiMessageType entry, `EditChat` and a new server-side handler function just for chat edits. The previous edit chat method simply *deleted* the chat from the client and created a new one. - Form validation is now more robust: you can now only submit the edit if you've made changes to the name or job title. - Fixed NanoChat not appearing in PDAs with more than 5 pre-installed programs by increasing the PDA disk space (max program count) from 5 to 8, the current disk space in Wizden.  - The job title now appears on the notification title.  - The title will be truncated if it's too long.  - Improved form validation on the New Chat popup by only allowing users to submit if the Number field is 4 numbers long. Previously, inputs like "0" "12" "289" were valid which is ultimately incorrect as phone numbers function more like strings that just happen to be digit-only and less like actual numbers.  - The left chat list will now truncate names and job titles if they're too long.  ## Changelog :cl: Skubman - add: NanoChat message notifications will now show you the job title of the sender alongside their name. - add: The NanoChat edit button now has a proper icon. - tweak: The disk space (max amount of installable programs) on PDAs has been increased from 5 to 8. This also fixes a bug where NanoChat was not being installed on PDAs with more than 5 pre-installed cartridges. - tweak: The character limit for names and job titles in NanoChat has been increased to their actual limit on ID cards (30 characters). - tweak: NanoChat chat list names/titles and notification titles that are too long will be shortened, indicated with "..." at the end. - tweak: The NanoChat edit popup now displays the correct text, instead of appearing identical to the new chat popup. - fix: NanoChat will now send a new message notification no matter what if you don't have the chat open. - fix: Editing a chat in NanoChat no longer deselects that chat. - fix: Fixed a issue where users could potentially send NanoChat messages longer than the maximum allowed message length. - fix: Fixed being able to create a new chat when you haven't typed in 4 digits in the number field.
# Description Increases the text limit for news reports: - Title character limit: 25 -> 50 - Content character limit: 2048 -> 2560 Mostly a personal change for me because I often run into the title character limits when I was playing Reporter. ## Media    ## Changelog :cl: Skubman - tweak: The news article title character limit has been increased from 25 to 50 characters, and news content from 2048 to 2560 characters.
<!-- This is a semi-strict format, you can add/remove sections as needed but the order/format should be kept the same Remove these comments before submitting --> # Description <!-- Explain this PR in as much detail as applicable Some example prompts to consider: How might this affect the game? The codebase? What might be some alternatives to this? How/Who does this benefit/hurt [the game/codebase]? --> This is [cherrypicked from wizden](space-wizards/space-station-14#28367). It literally just changes colors. See that PR for all information. # Why It bothered me that my 20 minutes of hard labor and 30 minutes arguing in github issues was not present on EE. I am since rectifying this blatant injustice. # Changelog <!-- You can add an author after the `:cl:` to change the name that appears in the changelog (ex: `:cl: Death`) Leaving it blank will default to your GitHub display name This includes all available types for the changelog --> :cl: - tweak: Some chemicals have been made more colorful and child-friendly. --------- Co-authored-by: sleepyyapril <123355664+sleepyyapril@users.noreply.github.com>
# Description Sets the Cybersun pen's throwing damage to be the same as its melee damage and also inflict embedded passive damage. Because the Cybersun pen inherits from `PenEmbeddable` that manually sets its own `DamageOtherOnHit` damage because it's not a melee weapon, the Cybersun pen's throwing damage didn't inherit the melee weapon damage and it was low compared to its melee damage. ## Media **New Damage Values**  **Old Damage Values**  ## Changelog :cl: Skubman - fix: The Cybersun pen now properly deals 15 Piercing damage on throw and deals passive damage when embedded.
# Description Fixed Shadow Shackles not activating when you melee hit the target. The Problem: The code checked if the target wasn't stunned when you hit someone, therefore not activating unless the target was already stunned. I fixed it by removing the ! operator on `HasComp<StunnedComponent>(target)` check. --- <details><summary><h1>Media</h1></summary> <p> https://github.com/user-attachments/assets/5ac1a5dd-5d62-4400-be64-56500c87ed5e </p> </details> --- # Changelog :cl: - fix: Fixed Shadow Shackles spell not activating.
# Description Fixes face markings rendering above clothing, most noticeably eye-wear by moving the Face layer below the Eyes layer on all species. ## Media Before (red markings rendering above sunglasses):  After:  # Changelog :cl: Skubman - fix: Fixed face markings showing up above eye-wear.
# Description Adds a prisoner headset box for warden's locker Reason: There's too much chaos in security and making radio headsets with pure encryption keys takes time and tools. More so cause by the time someone gets a perma punishment, its gonna be most likely late in the round and sec department will be dealing with a lot of things at the same time. --- <details><summary><h1>Media</h1></summary> <p>   </p> </details> --- # Changelog <!-- You can add an author after the `:cl:` to change the name that appears in the changelog (ex: `:cl: Death`) Leaving it blank will default to your GitHub display name This includes all available types for the changelog --> :cl: - add: Added prisoner headset box to warden's locker.
<!-- This is a semi-strict format, you can add/remove sections as needed but the order/format should be kept the same Remove these comments before submitting --> # Description <!-- Explain this PR in as much detail as applicable Some example prompts to consider: How might this affect the game? The codebase? What might be some alternatives to this? How/Who does this benefit/hurt [the game/codebase]? --> N1984 exists, but you can't print more ammo reliably. You can refill them, sure, but the moment you lose a magazine, it's gone forever. This adds the magazines and adds the unique mags to the research. Edit: Turns out there's like a lot missing in the lathe, so I decided to just add the missing ones I found. --- <!-- This is default collapsed, readers click to expand it and see all your media The PR media section can get very large at times, so this is a good way to keep it clean The title is written using HTML tags The title must be within the <summary> tags or you won't see it --> <details><summary><h1>Media</h1></summary> <p> Nothing here </p> </details> --- # Changelog <!-- You can add an author after the `:cl:` to change the name that appears in the changelog (ex: `:cl: Death`) Leaving it blank will default to your GitHub display name This includes all available types for the changelog --> :cl: - add: Added missing lathe recipes
<!-- This is a semi-strict format, you can add/remove sections as needed but the order/format should be kept the same Remove these comments before submitting --> # Description <!-- Explain this PR in as much detail as applicable Some example prompts to consider: How might this affect the game? The codebase? What might be some alternatives to this? How/Who does this benefit/hurt [the game/codebase]? --> When attempting to insert an organ, a check is now performed to ensure a container exists for it. Skeletons can now lie down, and nymphs can now be subject to surgery. --- # Changelog <!-- You can add an author after the `:cl:` to change the name that appears in the changelog (ex: `:cl: Death`) Leaving it blank will default to your GitHub display name This includes all available types for the changelog --> :cl: Spatison - tweak: Nymphs are now operable. - fix: Skeletons can now lie down. - fix: It is no longer possible to insert an organ into a body if the required space is unavailable.
<!-- This is a semi-strict format, you can add/remove sections as needed but the order/format should be kept the same Remove these comments before submitting --> # Description <!-- Explain this PR in as much detail as applicable Some example prompts to consider: How might this affect the game? The codebase? What might be some alternatives to this? How/Who does this benefit/hurt [the game/codebase]? --> Port from WWDP. Refactor from [Goob](Goob-Station/Goob-Station#1251) --- <!-- This is default collapsed, readers click to expand it and see all your media The PR media section can get very large at times, so this is a good way to keep it clean The title is written using HTML tags The title must be within the <summary> tags or you won't see it --> <details><summary><h1>Media</h1></summary> <p>  Night vision goggles:  Zealot's blindfold:  Animal vision:  Thermal vision goggles:  Deathsquad helmet:  Xeno vision:  </p> </details> --- # Changelog <!-- You can add an author after the `:cl:` to change the name that appears in the changelog (ex: `:cl: Death`) Leaving it blank will default to your GitHub display name This includes all available types for the changelog --> :cl: @Aviu00, Spatison, @PuroSlavKing - add: Added night vision goggle - add: Added thermal vision goggle - add: Deathsquad helmet now grants night and thermal vision. - add: Ninja visor now grants night vision. - tweak: Some animals have gained night vision. - tweak: Xenos have gained night vision. --------- Signed-off-by: Spatison <137375981+Spatison@users.noreply.github.com> Co-authored-by: PuroSlavKing <103608145+puroslavking@users.noreply.github.com>
# Description Thanks to @Spatison for the Night Vision PR. This PR adds traits for CyberEyes users that enables the use of either the Night Vision ability, or the Thermal Vision ability. The former lets you see in the dark (It can be toggled on and off at will). The latter lets you see living creatures through walls (for brief pulses). The latter is on the quite expensive side of things (12 trait points in total if you include the requirement that you first have CyberEyes). # TODO <details><summary><h1>Media</h1></summary> <p>  Sorry the pulse for thermographic was too short for me to be able to screenshot it. But it does work! </p> </details> # Changelog :cl: - add: Added 2 new traits related to CyberEyes. Light Amplification Module, and Thermographic Scanner Module.
Contributor
github-actions
bot
added
Changes: C#
Changes: Config
Changes: UI
Changes: Workflow
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Description.
TODO
Media
Changelog
🆑