optional verbose flag #181
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamdiallam
commented
Dec 25, 2019
colin-axner
previously requested changes
Dec 26, 2019
hamdiallam
force-pushed
the
hamdi/verbose
branch
from
ac36269
to
4f58e1f
Compare
Codecov Report
@@ Coverage Diff @@
## develop #181 +/- ##
===========================================
+ Coverage 52.02% 52.16% +0.14%
===========================================
Files 28 28
Lines 1359 1363 +4
===========================================
+ Hits 707 711 +4
Misses 538 538
Partials 114 114
Continue to review full report at Codecov.
|
wesgraham
approved these changes
Mar 17, 2020
colin-axner
approved these changes
Mar 17, 2020
| // transaction hash | ||
| txHash, err := hex.DecodeString(utils.RemoveHexPrefix(arg)) | ||
| if err != nil { | ||
| fmt.Printf("Error decoding tx hash hex-encoded string: %s\n", err) |
There was a problem hiding this comment.
What is the reasoning for printing the error as opposed to wrapping it? Also, error messages returned should begin with lowercase.
There was a problem hiding this comment.
that's a good point. Should just return it
| @@ -14,6 +14,7 @@ import ( | |||
| "strings" | |||
| ) | |||
|
|
|||
| // IncludeCmd - | |||
There was a problem hiding this comment.
do you plan to update these godoc's or nah?
There was a problem hiding this comment.
I'll update them. Found a bug in plasmad and paused on the cli work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #162
Add optional persistent verbose flag that can be reused across commands. Not used atm.
Added some godoc