Free up coupons from cancelled orders #2311
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalrus
commented
Jun 27, 2017
| def couponActiveFrom: Instant = Instant.now.minus(1, DAYS) | ||
| def couponActiveTo: Option[Instant] = None | ||
| def couponUsageRules: CouponUsageRules = | ||
| CouponUsageRules(isUnlimitedPerCode = true, isUnlimitedPerCustomer = true) |
There was a problem hiding this comment.
I’d argue they shouldn’t have defaults, either.
There was a problem hiding this comment.
Also cake pattern here is pretty unintuitive. I have to
- add another method parameter
- provide overrideable value that this method uses as a default
instead of
- just calling the function with arguments I want
| usesPerCustomer = Some(1) | ||
| ) | ||
|
|
||
| // TODO: extract CheckoutFixture and reuse it here (more refactoring will be needed for that) @michalrus |
| form ← * <~ ObjectForms.mustFindById400(coupon.formId) | ||
| couponUsage ← * <~ CouponUsages | ||
| .filterByCoupon(coupon.formId) | ||
| def incrementUsageCounts(codeId: Int, customer: User, incrementBy: Int)(implicit ec: EC, |
There was a problem hiding this comment.
If it’s None… just… don’t call it.
narma
approved these changes
Jun 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #1703