Conversation
greenc-FNAL
force-pushed
the
maintenance/rework-Dockerfile
branch
from
68cbe7b to
8ad866e
Compare
Specify repo locations
greenc-FNAL
force-pushed
the
maintenance/rework-Dockerfile
branch
2 times, most recently
from
a17a27e to
c226e7a
Compare
knoepfel
reviewed
Nov 10, 2025
Member
knoepfel
left a comment
knoepfel
left a comment
There was a problem hiding this comment.
Looks good, @greenc-FNAL. Have just one comment below.
knoepfel
approved these changes
Nov 10, 2025
greenc-FNAL
added a commit
that referenced
this pull request
Feb 13, 2026
Resolve 6 medium-severity code injection alerts (CodeQL #107, #105, #104, #103, #102, #100) in .github/actions/handle-fix-commit/action.yaml by moving user inputs to environment variables before use in shell commands. This follows GitHub Security Lab best practices for preventing code injection in GitHub Actions workflows: https://securitylab.github.com/research/github-actions-untrusted-input/ Changes: - Added env: section mapping all user inputs to environment variables - Updated shell script to use $VAR syntax instead of ${{ inputs.X }} syntax - Properly quoted all variable references to prevent word splitting Inputs affected: - inputs.token → $TOKEN - inputs.tool → $TOOL - inputs.retry-attempts → $RETRY_ATTEMPTS - inputs.pr-info-ref → $PR_REF
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a multi-target
Dockerfileinstead ofci/Dockerfilebeing the basis of aFROM ...for a dev image.This avoids ownership/uid/permission/Spack cache issues in both CI and dev containers, while maximizing both Dockerfile maintainability/reuse, and image layer reuse.