Skip to content

Clang-tidy configuration adjustment#102

Merged
knoepfel merged 2 commits intoFramework-R-D:mainfrom
knoepfel:clang-tidy-adjustment
Nov 13, 2025
Merged

Clang-tidy configuration adjustment#102
knoepfel merged 2 commits intoFramework-R-D:mainfrom
knoepfel:clang-tidy-adjustment

Conversation

@knoepfel
Copy link
Copy Markdown
Member

@knoepfel knoepfel commented Nov 10, 2025

This PR makes some adjustments to the clang-tidy configuration:

  • Ensure const data members have a trailing underscore as a suffix
  • Remove limit of 6 parameters on functions (not a formal C++ code guideline)

@knoepfel knoepfel force-pushed the clang-tidy-adjustment branch from 84eb3af to cf68e3a Compare November 10, 2025 19:40
@knoepfel knoepfel mentioned this pull request Nov 10, 2025
@knoepfel knoepfel requested a review from greenc-FNAL November 11, 2025 17:20
@knoepfel knoepfel merged commit 782da97 into Framework-R-D:main Nov 13, 2025
17 checks passed
@knoepfel knoepfel deleted the clang-tidy-adjustment branch November 13, 2025 14:45
greenc-FNAL added a commit that referenced this pull request Feb 13, 2026
Resolve 6 medium-severity code injection alerts (CodeQL #107, #105, #104, #103, #102, #100)
in .github/actions/handle-fix-commit/action.yaml by moving user inputs to environment
variables before use in shell commands.

This follows GitHub Security Lab best practices for preventing code injection in
GitHub Actions workflows:
https://securitylab.github.com/research/github-actions-untrusted-input/

Changes:
- Added env: section mapping all user inputs to environment variables
- Updated shell script to use $VAR syntax instead of ${{ inputs.X }} syntax
- Properly quoted all variable references to prevent word splitting

Inputs affected:
- inputs.token → $TOKEN
- inputs.tool → $TOOL
- inputs.retry-attempts → $RETRY_ATTEMPTS
- inputs.pr-info-ref → $PR_REF
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants