Skip to content

Remove DOT file generation#116

Merged
knoepfel merged 3 commits intoFramework-R-D:mainfrom
knoepfel:remove-dot-generation
Nov 14, 2025
Merged

Remove DOT file generation#116
knoepfel merged 3 commits intoFramework-R-D:mainfrom
knoepfel:remove-dot-generation

Conversation

@knoepfel
Copy link
Copy Markdown
Member

Closes #86 (removing automatic Graphviz file generation).

@knoepfel
Copy link
Copy Markdown
Member Author

@phlexbot format

@github-actions
Copy link
Copy Markdown
Contributor

No code-formatting changes to make

@github-actions
Copy link
Copy Markdown
Contributor

CMake formatting changes pushed (commit 432554a)

@knoepfel knoepfel closed this Nov 13, 2025
@knoepfel knoepfel reopened this Nov 13, 2025
@knoepfel knoepfel requested a review from greenc-FNAL November 13, 2025 19:55
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main     #116      +/-   ##
==========================================
- Coverage   81.67%   80.22%   -1.46%     
==========================================
  Files         118      115       -3     
  Lines        2074     1906     -168     
  Branches      336      302      -34     
==========================================
- Hits         1694     1529     -165     
- Misses        244      247       +3     
+ Partials      136      130       -6     
Flag Coverage Δ
unittests 80.22% <100.00%> (-1.46%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
phlex/app/phlex.cpp 66.03% <100.00%> (-0.10%) ⬇️
phlex/app/run.cpp 100.00% <100.00%> (ø)
phlex/core/edge_maker.hpp 100.00% <100.00%> (+5.35%) ⬆️
phlex/core/framework_graph.cpp 83.75% <100.00%> (-0.78%) ⬇️
phlex/core/framework_graph.hpp 100.00% <ø> (ø)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7106b4d...09b9d2c. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@knoepfel knoepfel requested a review from marcpaterno November 13, 2025 20:06
@greenc-FNAL
Copy link
Copy Markdown
Contributor

Argh, sorry. I know that was assigned to me and I was going to get there, honest.

@knoepfel
Copy link
Copy Markdown
Member Author

Argh, sorry. I know that was assigned to me and I was going to get there, honest.

Oh...really? Oops. Didn't mean to step on toes. Clearly I didn't remember.

In any case, if you don't mind looking this over, I'd appreciate it. We can chat in person if necessary.

Copy link
Copy Markdown
Contributor

@greenc-FNAL greenc-FNAL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good to me. My one concern is whether there might still be vestigial code hanging out somewhere. Are you confident this is complete, or are there any more checks that can be done to give us that confidence?

@knoepfel
Copy link
Copy Markdown
Member Author

Looks pretty good to me. My one concern is whether there might still be vestigial code hanging out somewhere. Are you confident this is complete, or are there any more checks that can be done to give us that confidence?

I've done a search for graphviz and dot, and those come up empty. However, there are some stragglers for files with .gv extensions. Another change coming.

@knoepfel knoepfel merged commit f896b93 into Framework-R-D:main Nov 14, 2025
22 checks passed
@knoepfel knoepfel deleted the remove-dot-generation branch November 14, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove Graphviz file generation

2 participants