Remove DOT file generation#116
Conversation
|
@phlexbot format |
|
No code-formatting changes to make |
|
CMake formatting changes pushed (commit 432554a) |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #116 +/- ##
==========================================
- Coverage 81.67% 80.22% -1.46%
==========================================
Files 118 115 -3
Lines 2074 1906 -168
Branches 336 302 -34
==========================================
- Hits 1694 1529 -165
- Misses 244 247 +3
+ Partials 136 130 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
Argh, sorry. I know that was assigned to me and I was going to get there, honest. |
Oh...really? Oops. Didn't mean to step on toes. Clearly I didn't remember. In any case, if you don't mind looking this over, I'd appreciate it. We can chat in person if necessary. |
greenc-FNAL
left a comment
There was a problem hiding this comment.
Looks pretty good to me. My one concern is whether there might still be vestigial code hanging out somewhere. Are you confident this is complete, or are there any more checks that can be done to give us that confidence?
I've done a search for |
Closes #86 (removing automatic Graphviz file generation).