Skip to content

Update tests according to @marcpaterno's suggestions

aacdc3f
Select commit
Loading
Failed to load commit list.
Merged

Refactor caching of data for multilayer algorithms #118

Update tests according to @marcpaterno's suggestions
aacdc3f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 24, 2026 in 0s

83.22% (target 80.00%)

View this Pull Request on Codecov

83.22% (target 80.00%)

Details

Codecov Report

❌ Patch coverage is 94.63087% with 24 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
phlex/core/index_router.cpp 91.74% 5 Missing and 4 partials ⚠️
phlex/core/multilayer_join_node.hpp 90.19% 2 Missing and 3 partials ⚠️
phlex/core/detail/repeater_node.cpp 95.78% 0 Missing and 4 partials ⚠️
phlex/core/declared_fold.hpp 95.23% 2 Missing ⚠️
phlex/core/declared_provider.cpp 0.00% 1 Missing ⚠️
phlex/core/declared_unfold.cpp 75.00% 1 Missing ⚠️
phlex/core/declared_unfold.hpp 96.00% 1 Missing ⚠️
phlex/core/store_counters.cpp 50.00% 0 Missing and 1 partial ⚠️
@@            Coverage Diff             @@
##             main     #118      +/-   ##
==========================================
+ Coverage   82.24%   83.22%   +0.98%     
==========================================
  Files         127      129       +2     
  Lines        3103     3220     +117     
  Branches      547      546       -1     
==========================================
+ Hits         2552     2680     +128     
+ Misses        334      329       -5     
+ Partials      217      211       -6     
Files with missing lines Coverage Δ
phlex/core/declared_observer.cpp 100.00% <ø> (+66.66%) ⬆️
phlex/core/declared_observer.hpp 100.00% <100.00%> (ø)
phlex/core/declared_output.cpp 100.00% <100.00%> (ø)
phlex/core/declared_predicate.cpp 100.00% <ø> (+50.00%) ⬆️
phlex/core/declared_predicate.hpp 94.73% <100.00%> (+5.08%) ⬆️
phlex/core/declared_provider.hpp 100.00% <100.00%> (ø)
phlex/core/declared_transform.cpp 100.00% <ø> (ø)
phlex/core/declared_transform.hpp 89.47% <100.00%> (-1.84%) ⬇️
phlex/core/edge_maker.cpp 77.27% <100.00%> (ø)
phlex/core/edge_maker.hpp 100.00% <100.00%> (ø)
... and 19 more

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67d1adc...aacdc3f. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.