Fix "source" name issues for product_store#121
Merged
Conversation
Contributor
Author
|
@phlexbot format |
Contributor
|
Code-formatting changes pushed (commit 1629297) |
Contributor
|
No CMake formatting changes to make |
knoepfel
reviewed
Nov 18, 2025
Member
knoepfel
left a comment
knoepfel
left a comment
There was a problem hiding this comment.
Thanks, @greenc-FNAL, for the PR. Just a few comments below.
greenc-FNAL
force-pushed
the
bugfix/fix-source-name
branch
from
1629297 to
56a8cc0
Compare
greenc-FNAL
added a commit
that referenced
this pull request
Nov 19, 2025
See #121 (comment) Co-authored-by: Kyle Knoepfel <knoepfel@fnal.gov>
greenc-FNAL
added a commit
that referenced
this pull request
Nov 19, 2025
Contributor
Author
|
@phlexbot format |
Contributor
|
No CMake formatting changes to make |
Contributor
|
Code-formatting changes pushed (commit a6aa7fd) |
greenc-FNAL
added a commit
that referenced
this pull request
Nov 19, 2025
greenc-FNAL
force-pushed
the
bugfix/fix-source-name
branch
from
a6aa7fd to
de920f3
Compare
See #121 (comment) Co-authored-by: Kyle Knoepfel <knoepfel@fnal.gov> Committing clang-format changes
greenc-FNAL
force-pushed
the
bugfix/fix-source-name
branch
from
de920f3 to
e4babca
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #121 +/- ##
==========================================
+ Coverage 80.22% 80.26% +0.04%
==========================================
Files 115 115
Lines 1906 1910 +4
Branches 302 302
==========================================
+ Hits 1529 1533 +4
Misses 247 247
Partials 130 130
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Contributor
Author
|
@phlexbot format |
Contributor
|
Code-formatting changes pushed (commit c30a3b9) |
Contributor
|
No CMake formatting changes to make |
knoepfel
approved these changes
Nov 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #120.
#120 reported that diagnostic output in tests was empty or malformed.
The malformed output was due to
product_storesaving astring_viewto a temporary string provided at construction time.The empty output had two different causes:
base()product store was not initialized with a name.hierarchical_nodes) creates child product stores without providing a name.strings are passed and saved rather thanstring_views.staticmember functionproduct_store::base()to accept an optionalbase_name, which defaults to "Source" if not provided.There remains a question of whether
product_store::make_child()should: