CI workflow to run Python ruff/mypy checks#133
Merged
Conversation
Contributor
Author
|
@phlexbot format |
Refactors the `python-check.yaml` and `python-fix.yaml` GitHub Actions workflows to align with the structure and conventions of their Clang counterparts. - In `python-check.yaml`, introduces a `pre-check` job to separate environment detection, improving the workflow's dependency graph and clarity. - In `python-fix.yaml`, enhances the issue comment trigger by moving the validation logic directly into the job's `if` condition. This is more efficient and secure, preventing the job from starting unnecessarily. - Standardizes the pinning of third-party actions to commit SHAs and local actions to the `main` branch across both workflows.
greenc-FNAL
force-pushed
the
jules-feature-add-python-workflows
branch
from
cfff989 to
34c4f14
Compare
This commit aligns the `python-check.yaml` and `python-fix.yaml` workflows with the consistency improvements and standards established in PR #135. Key changes include: - Refactoring `python-fix.yaml` to use a single-job design, moving the trigger logic into a job-level `if` condition. - Correcting the `uses` syntax for internal reusable actions to use the full repository path and pin to `@main`, resolving a syntax error (`@main@main`).
knoepfel
approved these changes
Dec 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resubmission of #126