Skip to content

Update terminology to agree with CDR#136

Merged
marcpaterno merged 8 commits intoFramework-R-D:mainfrom
knoepfel:update-terminology
Dec 4, 2025
Merged

Update terminology to agree with CDR#136
marcpaterno merged 8 commits intoFramework-R-D:mainfrom
knoepfel:update-terminology

Conversation

@knoepfel
Copy link
Member

@knoepfel knoepfel commented Dec 1, 2025

Closes #128.

@codecov
Copy link

codecov bot commented Dec 1, 2025

Codecov Report

❌ Patch coverage is 82.50000% with 28 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
phlex/model/data_cell_index.cpp 75.71% 14 Missing and 3 partials ⚠️
phlex/model/data_cell_counter.hpp 50.00% 4 Missing and 1 partial ⚠️
phlex/core/multiplexer.cpp 66.66% 0 Missing and 2 partials ⚠️
phlex/core/product_query.hpp 0.00% 1 Missing ⚠️
phlex/model/data_cell_counter.cpp 95.23% 0 Missing and 1 partial ⚠️
phlex/model/data_layer_hierarchy.cpp 93.33% 0 Missing and 1 partial ⚠️
phlex/model/product_matcher.cpp 80.00% 1 Missing ⚠️
@@            Coverage Diff             @@
##             main     #136      +/-   ##
==========================================
- Coverage   81.14%   81.09%   -0.05%     
==========================================
  Files         116      116              
  Lines        2042     2042              
  Branches      326      326              
==========================================
- Hits         1657     1656       -1     
  Misses        250      250              
- Partials      135      136       +1     
Flag Coverage Δ
unittests 81.09% <82.50%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
phlex/core/cached_product_stores.hpp 100.00% <100.00%> (ø)
phlex/core/declared_fold.hpp 92.98% <100.00%> (ø)
phlex/core/declared_observer.cpp 33.33% <ø> (ø)
phlex/core/declared_observer.hpp 100.00% <ø> (ø)
phlex/core/declared_predicate.hpp 89.65% <ø> (ø)
phlex/core/declared_transform.hpp 91.48% <100.00%> (ø)
phlex/core/declared_unfold.cpp 60.00% <100.00%> (ø)
phlex/core/declared_unfold.hpp 94.54% <100.00%> (ø)
phlex/core/end_of_message.cpp 100.00% <ø> (ø)
phlex/core/framework_graph.cpp 83.75% <100.00%> (ø)
... and 19 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe26288...c73cd4e. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@knoepfel knoepfel force-pushed the update-terminology branch 2 times, most recently from 3eb550f to a4984ca Compare December 2, 2025 19:04
@marcpaterno marcpaterno merged commit 90c1a2c into Framework-R-D:main Dec 4, 2025
36 checks passed
@greenc-FNAL greenc-FNAL mentioned this pull request Dec 4, 2025
16 tasks
Copilot AI added a commit that referenced this pull request Dec 4, 2025
…e levels_ to layers_

Co-authored-by: greenc-FNAL <2372949+greenc-FNAL@users.noreply.github.com>
Copilot AI added a commit that referenced this pull request Dec 4, 2025
…e levels_ to layers_

Co-authored-by: greenc-FNAL <2372949+greenc-FNAL@users.noreply.github.com>
knoepfel pushed a commit that referenced this pull request Dec 4, 2025
…els_` to `layers_` (#160)

* Apply patches from issue #136 late review: fix header guard and rename levels_ to layers_
* Remove codeql artifact and add to gitignore

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: greenc-FNAL <2372949+greenc-FNAL@users.noreply.github.com>
@knoepfel knoepfel deleted the update-terminology branch December 4, 2025 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adjust terminology in Phlex repository to match CDR

2 participants