Fix workflow issues caught by actionlint#139
Merged
greenc-FNAL merged 2 commits intoFramework-R-D:mainfrom Dec 2, 2025
Merged
Conversation
Contributor
greenc-FNAL
commented
Dec 2, 2025
greenc-FNAL
commented
- fix(workflows): Resolve actionlint warnings and logic in CI
- Fix variable/command output splitting with double quotes
This commit addresses multiple `actionlint` warnings and improves the robustness of the CI workflows. - **clang-tidy-fix.yaml**: Mitigates a script injection warning by passing the untrusted `github.event.comment.body` through a sanitized environment variable before use in the `run` script. - **cmake-build.yaml**: Refactors the job structure to resolve property warnings and a logic flaw that prevented manual triggers from running correctly. The change separates change-detection and matrix-generation into two distinct, lightweight jobs, ensuring the build runs correctly for all trigger types.
Contributor
Author
[greenc@scisoftbuild02] phlex (main) $ docker run --rm -v $(pwd):/repo --workdir /repo rhysd/actionlint:latest | grep -Ece '^\.github/'
13
[greenc@scisoftbuild02] phlex (main) $ git switch -
Switched to branch 'maintenance/actionlint-fixes'
Your branch is up to date with 'greenc-FNAL/maintenance/actionlint-fixes'.
[greenc@scisoftbuild02] phlex (maintenance/actionlint-fixes) $ docker run --rm -v $(pwd):/repo --workdir /repo rhysd/actionlint:latest | grep -Ece '^\.github/'
0 |
knoepfel
approved these changes
Dec 2, 2025
knoepfel
pushed a commit
to knoepfel/phlex
that referenced
this pull request
Dec 2, 2025
* fix(workflows): Resolve actionlint warnings and logic in CI This commit addresses multiple `actionlint` warnings and improves the robustness of the CI workflows. - **clang-tidy-fix.yaml**: Mitigates a script injection warning by passing the untrusted `github.event.comment.body` through a sanitized environment variable before use in the `run` script. - **cmake-build.yaml**: Refactors the job structure to resolve property warnings and a logic flaw that prevented manual triggers from running correctly. The change separates change-detection and matrix-generation into two distinct, lightweight jobs, ensuring the build runs correctly for all trigger types. * Fix variable/command output splitting with double quotes --------- Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.