Mandate the specification of the data layer in input_family(...)#155
Merged
marcpaterno merged 10 commits intoFramework-R-D:mainfrom Dec 5, 2025
Merged
Mandate the specification of the data layer in input_family(...)#155marcpaterno merged 10 commits intoFramework-R-D:mainfrom
input_family(...)#155marcpaterno merged 10 commits intoFramework-R-D:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #155 +/- ##
==========================================
- Coverage 81.31% 80.90% -0.42%
==========================================
Files 115 115
Lines 2039 2042 +3
Branches 328 330 +2
==========================================
- Hits 1658 1652 -6
- Misses 249 256 +7
- Partials 132 134 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
knoepfel
force-pushed
the
mandate-data-layer
branch
3 times, most recently
from
e11aa81 to
467a741
Compare
beojan
reviewed
Dec 4, 2025
knoepfel
force-pushed
the
mandate-data-layer
branch
from
37c63f0 to
65b587a
Compare
marcpaterno
approved these changes
Dec 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR requires all arguments in the
input_family(...)clause to include the data layer (per Phlex developer discussion)This PR also includes miscellaneous changes:
async_driver's driver thread are now captured and rethrown from the main thread