Skip to content

Fix Jsonnet Library Loading On MacOS #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knoepfel merged 5 commits into from
Dec 8, 2025
Merged

Fix Jsonnet Library Loading On MacOS #170

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cb5ec7d
Fix Jsonnet Library Loading On MacOS
marcpaterno Dec 8, 2025
3c92e64
Update Modules/Findjsonnet.cmake
marcpaterno Dec 8, 2025
55229b0
Apply CMake format
knoepfel Dec 8, 2025
b6f059d
Add comment of when to remove macOS hack from Findjsonnet.cmake
marcpaterno Dec 8, 2025
5f9434d
Make cmake-format happy
knoepfel Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 41 additions & 0 deletions Modules/Findjsonnet.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,47 @@ if(${CMAKE_FIND_PACKAGE_NAME}_FOUND)
set(${CMAKE_FIND_PACKAGE_NAME}_INCLUDE_DIRS
${${CMAKE_FIND_PACKAGE_NAME}_INCLUDE_DIRS}
)

# On macOS, fix jsonnet libraries if they have incorrect install_name
#
# This should be removed when the Spack recipe is updated to create the
# correct install_name.
if(APPLE)
foreach(_lib ${${CMAKE_FIND_PACKAGE_NAME}_LIBRARY}
${${CMAKE_FIND_PACKAGE_NAME}_CLIBRARY}
)
if(EXISTS "${_lib}")
# Get the library's current install_name
execute_process(
COMMAND otool -D "${_lib}"
OUTPUT_VARIABLE _install_name_output
OUTPUT_STRIP_TRAILING_WHITESPACE ERROR_QUIET
)
# Extract just the install_name (second line of output)
string(REGEX REPLACE "^[^\n]+\n(.+)$" "\\1" _current_install_name
"${_install_name_output}"
)
get_filename_component(_lib_name "${_lib}" NAME)
# Check if install_name needs fixing (doesn't start with @ or /)
if(_current_install_name MATCHES "^[^/@]")
message(
STATUS
"Fixing install_name for ${_lib_name}: ${_current_install_name} -> @rpath/${_current_install_name}"
)
execute_process(
COMMAND install_name_tool -id "@rpath/${_current_install_name}"
"${_lib}"
RESULT_VARIABLE _fix_result
ERROR_QUIET
)
if(NOT _fix_result EQUAL 0)
message(WARNING "Failed to fix install_name for ${_lib_name}")
endif()
endif()
endif()
endforeach()
endif()

if(NOT TARGET jsonnet::lib)
add_library(jsonnet::lib SHARED IMPORTED)
set_target_properties(
Expand Down
Loading