Remove unused cached_product_stores class#176
Merged
knoepfel merged 1 commit intoFramework-R-D:mainfrom Dec 9, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #176 +/- ##
==========================================
+ Coverage 80.93% 81.00% +0.06%
==========================================
Files 115 114 -1
Lines 2046 2037 -9
Branches 330 328 -2
==========================================
- Hits 1656 1650 -6
+ Misses 256 254 -2
+ Partials 134 133 -1
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
greenc-FNAL
approved these changes
Dec 9, 2025
Contributor
greenc-FNAL
left a comment
greenc-FNAL
left a comment
There was a problem hiding this comment.
LGTM: negative lines of code is always the best metric.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
cached_product_storesclass is vestigial and no longer used. This PR removes it and its corresponding test.