Add FORM output module for phlex product_store integration by barnaliy · Pull Request #177 · Framework-R-D/phlex

barnaliy · 2025-12-09T22:18:27Z

No description provided.

…ion-work

Implements FormOutputModule that integrates phlex's product_store with FORM's persistence layer. The module extracts products from phlex stores and writes them using configurable FORM backend technologies. Key changes: - form_module.cpp: New output module with phlex product_store integration - Updates to form/CMakeLists.txt to build form_module library - Links against phlex::module and phlex::experimental interfaces Note: Requires phlex standalone build modifications (submitted separately)

…ntal directly) , 2. Create test_helpers.hpp with createTypeMap() implementation, 3. Register TrackStart and vector<TrackStart> types for FORM serialization, 4. Update writer.cpp and reader.cpp to use form::experimental namespace, 5. Tests now build against form library directly without mock layer

barnaliy · 2025-12-10T21:20:33Z

@phlexbot format

github-actions · 2025-12-10T21:20:59Z

Automatic fixes pushed (commit eeffe13).
⚠️ Note: Some issues may require manual review and fixing.

github-actions · 2025-12-10T21:21:01Z

No automatic fixes were necessary.

… full build)

form/CMakeLists.txt

form/form/form.hpp

codecov · 2025-12-11T21:59:56Z

Codecov Report

❌ Patch coverage is 85.52632% with 11 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
form/form_module.cpp	87.50%	6 Missing and 1 partial ⚠️
form/form/form.cpp	88.23%	1 Missing and 1 partial ⚠️
form/root_storage/root_ttree_container.cpp	33.33%	1 Missing and 1 partial ⚠️

@@            Coverage Diff             @@
##             main     #177      +/-   ##
==========================================
+ Coverage   82.01%   82.27%   +0.25%     
==========================================
  Files         120      118       -2     
  Lines        2174     2211      +37     
  Branches      348      353       +5     
==========================================
+ Hits         1783     1819      +36     
- Misses        253      259       +6     
+ Partials      138      133       -5

Flag	Coverage Δ
unittests	`82.27% <85.52%> (+0.25%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
form/form/form.hpp	`100.00% <ø> (ø)`
form/form/form.cpp	`77.14% <88.23%> (-3.81%)`	⬇️
form/root_storage/root_ttree_container.cpp	`46.15% <33.33%> (-3.85%)`	⬇️
form/form_module.cpp	`87.50% <87.50%> (ø)`

... and 6 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57dcdf2...cd323e2. Read the comment docs.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

form/form_module.cpp

…OutputModule by running a Phlex workflow that uses the form_module plugin, improving code coverage for form_module.cpp. The test follows the same pattern as test/plugins, using a jsonnet configuration file to instantiate and run the module through Phlex.

knoepfel

@barnaliy, please try this change

form/CMakeLists.txt

pcanal · 2025-12-17T20:50:52Z

The problem may be that the tree is written in the destructor, but by that time the TFile might already be closed or the directory association lost!

The problem was already solved by c6a1464

form/form_module.cpp

This is a tempoary work-around until std::type_info is part of the Phlex API. Adding support for: long, float, double and std::vector of int, long, float and double.

pcanal · 2025-12-17T22:21:01Z

@barnaliy @gemmeren I added another commit 9b49214 to extent the list of support types.

If we can address #177 (comment) then we have enough in place to support arbitrary simple configured products (instead of hard coding a single product).

gemmeren · 2025-12-17T22:26:52Z

Thanks Philippe,
for adding the basic/native types. @barnaliy Maybe bool, char and string can be added as well (can be separate PR).

…comment)Removed hardcoded 'sum' registration. FormOutputModule now reads product names from the jsonnet config 'products' field, making it generic for any configured products.

knoepfel · 2025-12-18T17:05:54Z

@phlexbot format

github-actions · 2025-12-18T17:06:21Z

No automatic fixes were necessary.

github-actions · 2025-12-18T17:06:26Z

Automatic fixes pushed (commit d6ae99a).
⚠️ Note: Some issues may require manual review and fixing.

knoepfel · 2025-12-18T17:18:43Z

@barnaliy and @pcanal, we now have successful builds and tests. Does anything else need to be done before approving and merging this PR?

form/form_module.cpp

pcanal

LGTM. Thanks.

barnaliy · 2025-12-18T18:54:43Z

🎉 Thank you all!

gemmeren · 2025-12-18T21:19:29Z

Thanks for all your work 😃 .

knoepfel and others added 7 commits December 1, 2025 17:00

Skeleton of Phlex/FORM integration module

9b5550f

Merge remote-tracking branch 'origin/main' into barnali/form-integrat…

692a1ea

…ion-work

Change to form::experimental::product_with_name

cfa3d5a

Add test_helpers.hpp with createTypeMap implementation for FORM tests

a180834

Apply clang-format to FORM integration and test files

8cf4609

barnaliy requested review from gemmeren, knoepfel and pcanal December 10, 2025 21:02

Remove mock_phlex directory

17ba271

Apply cmake-format fixes

eeffe13

barnaliy added 3 commits December 10, 2025 15:46

Remove phlex::experimental dependency from form_module (not needed in…

aadbe69

… full build)

Merge phlexbot formatting changes

bf8a58c

Remove phlex::experimental from form_module dependencies

63e32b1

gemmeren reviewed Dec 11, 2025

View reviewed changes

form/CMakeLists.txt Outdated Show resolved Hide resolved

pcanal reviewed Dec 11, 2025

View reviewed changes

form/form/form.hpp Outdated Show resolved Hide resolved

Remove temporary comments and duplicate lines

f68cf4d

barnaliy marked this pull request as ready for review December 11, 2025 22:05

pcanal reviewed Dec 12, 2025

View reviewed changes

form/form_module.cpp Show resolved Hide resolved

gemmeren self-requested a review December 12, 2025 20:20

gemmeren previously approved these changes Dec 12, 2025

View reviewed changes

barnaliy dismissed gemmeren’s stale review via 7db2419 December 12, 2025 21:31

Trivial comment removed

f3ba8dd

knoepfel reviewed Dec 12, 2025

View reviewed changes

form/CMakeLists.txt Outdated Show resolved Hide resolved

Fixing...

a1d8125

pcanal self-requested a review December 17, 2025 22:10

pcanal reviewed Dec 17, 2025

View reviewed changes

form/form_module.cpp Outdated Show resolved Hide resolved

Form: register more supported type.

9b49214

This is a tempoary work-around until std::type_info is part of the Phlex API. Adding support for: long, float, double and std::vector of int, long, float and double.

pcanal self-requested a review December 17, 2025 22:21

gemmeren previously approved these changes Dec 17, 2025

View reviewed changes

fix: Read products from config instead of hardcoding (addresses PC's …

fdf681c

…comment)Removed hardcoded 'sum' registration. FormOutputModule now reads product names from the jsonnet config 'products' field, making it generic for any configured products.

barnaliy dismissed gemmeren’s stale review via fdf681c December 18, 2025 15:42

fix: Use simple array for products config per Kyle's suggestion

ec53af3

Commit from GitHub Actions (Clang-Format Fix)

d6ae99a

pcanal reviewed Dec 18, 2025

View reviewed changes

form/form_module.cpp Outdated Show resolved Hide resolved

barnaliy and others added 4 commits December 18, 2025 11:46

fix: Pass by const reference

56239b3

Merge branch 'main' into barnali/form-integration-work

1e13a7e

Do not move products_to_save vector

45eae1e

Adjust PHLEX_PLUGIN_PATH for form_module test

cd323e2

pcanal self-requested a review December 18, 2025 18:46

pcanal approved these changes Dec 18, 2025

View reviewed changes

knoepfel merged commit ec29fea into main Dec 18, 2025
36 checks passed

knoepfel deleted the barnali/form-integration-work branch December 18, 2025 18:51

This was referenced Dec 18, 2025

Add verification step to FORM test. #207

Open

Provider based on FORM #208

Open

Conversation

barnaliy commented Dec 9, 2025

Uh oh!

barnaliy commented Dec 10, 2025

Uh oh!

github-actions bot commented Dec 10, 2025

Uh oh!

github-actions bot commented Dec 10, 2025

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

knoepfel left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pcanal commented Dec 17, 2025

Uh oh!

Uh oh!

pcanal commented Dec 17, 2025

Uh oh!

gemmeren commented Dec 17, 2025

Uh oh!

knoepfel commented Dec 18, 2025

Uh oh!

github-actions bot commented Dec 18, 2025

Uh oh!

github-actions bot commented Dec 18, 2025

Uh oh!

knoepfel commented Dec 18, 2025

Uh oh!

Uh oh!

pcanal left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

barnaliy commented Dec 18, 2025

Uh oh!

gemmeren commented Dec 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented Dec 11, 2025 •

edited

Loading