Skip to content

Driver that generates layers according to configuration#179

Merged
marcpaterno merged 12 commits intoFramework-R-D:mainfrom
knoepfel:layer-generator-driver
Dec 16, 2025
Merged

Driver that generates layers according to configuration#179
marcpaterno merged 12 commits intoFramework-R-D:mainfrom
knoepfel:layer-generator-driver

Conversation

@knoepfel
Copy link
Member

@knoepfel knoepfel commented Dec 10, 2025

Closes #145.

@knoepfel knoepfel marked this pull request as draft December 10, 2025 14:08
@knoepfel knoepfel force-pushed the layer-generator-driver branch 3 times, most recently from c5871f0 to d0435f2 Compare December 10, 2025 22:22
@knoepfel
Copy link
Member Author

@phlexbot format

@github-actions
Copy link
Contributor

No automatic fixes were necessary.

@github-actions
Copy link
Contributor

Automatic fixes pushed (commit 692e399).
⚠️ Note: Some issues may require manual review and fixing.

@codecov
Copy link

codecov bot commented Dec 10, 2025

Codecov Report

❌ Patch coverage is 97.56098% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
plugins/layer_generator.cpp 96.96% 0 Missing and 2 partials ⚠️
@@            Coverage Diff             @@
##             main     #179      +/-   ##
==========================================
+ Coverage   81.32%   82.10%   +0.77%     
==========================================
  Files         117      120       +3     
  Lines        2099     2179      +80     
  Branches      332      349      +17     
==========================================
+ Hits         1707     1789      +82     
+ Misses        255      252       -3     
- Partials      137      138       +1     
Flag Coverage Δ
unittests 82.10% <97.56%> (+0.77%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
phlex/model/data_cell_index.cpp 77.63% <100.00%> (+1.91%) ⬆️
phlex/model/data_cell_index.hpp 100.00% <ø> (ø)
plugins/generate_layers.cpp 100.00% <100.00%> (ø)
plugins/layer_generator.hpp 100.00% <100.00%> (ø)
plugins/layer_generator.cpp 96.96% <96.96%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc53453...87d4870. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@knoepfel knoepfel force-pushed the layer-generator-driver branch from 692e399 to 1ff001d Compare December 11, 2025 21:16
@knoepfel knoepfel marked this pull request as ready for review December 11, 2025 21:17
@knoepfel knoepfel force-pushed the layer-generator-driver branch 3 times, most recently from 033d7e6 to 2392151 Compare December 15, 2025 19:17
@marcpaterno marcpaterno self-requested a review December 16, 2025 14:20
@knoepfel knoepfel force-pushed the layer-generator-driver branch from 9599f49 to 87d4870 Compare December 16, 2025 17:34
@marcpaterno marcpaterno merged commit 1db3413 into Framework-R-D:main Dec 16, 2025
36 checks passed
@knoepfel knoepfel deleted the layer-generator-driver branch December 16, 2025 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement driver that emits user-defined layer hierarchy

2 participants