Remember to send flushes for unfolded data layers#183
Merged
marcpaterno merged 1 commit intoFramework-R-D:mainfrom Dec 12, 2025
Merged
Remember to send flushes for unfolded data layers#183marcpaterno merged 1 commit intoFramework-R-D:mainfrom
marcpaterno merged 1 commit intoFramework-R-D:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #183 +/- ##
==========================================
+ Coverage 81.13% 81.15% +0.01%
==========================================
Files 116 116
Lines 2083 2085 +2
Branches 332 332
==========================================
+ Hits 1690 1692 +2
Misses 255 255
Partials 138 138
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
a420324 to
d2f5ebc
Compare
marcpaterno
approved these changes
Dec 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each processed data cell has a corresponding "flush" message that is emitted to indicate that that data cell is complete. Such flush messages are not being emitted for data cells produced by an unfold node, yielding unnecessary caching:
This PR fixes this problem: